search

supersaiyanmode / PyWebOSTV

Python API for controlling LG TVs (Web OS)
MIT License
261 stars 50 forks source link

add more clarity to using client key #46

Closed thevickypedia closed 3 years ago

thevickypedia commented 3 years ago

merge it or drop it, just felt it would be more clearer this way

supersaiyanmode commented 3 years ago

I think the only way readers understand "store" is if I write a quick sample code. I will do it soon.

thevickypedia commented 3 years ago

I think the only way readers understand "store" is if I write a quick sample code. I will do it soon.

I'm on it now, leaving your part untouched will add few lines to explain it better. Your suggestion really makes sense :)

coveralls commented 3 years ago

Coverage Status

Coverage remained the same at 84.161% when pulling 668c44bf7c2683c5a1a0f23b65947744e7dae1d7 on thevickypedia:patch-1 into fb0b826d34d5238b752c869a5d81de92458e99fa on supersaiyanmode:master.

supersaiyanmode commented 3 years ago

Please take a look at this PR https://github.com/supersaiyanmode/PyWebOSTV/pull/47. Let me know if this addresses your questions. I modified quite a few areas of README.md

thevickypedia commented 3 years ago

Please take a look at this PR #47. Let me know if this addresses your questions. I modified quite a few areas of README.md

That's a lot more than what I was expecting :D Thanks for asking my opinion too 👍🏼

supersaiyanmode commented 3 years ago

Sure! Feel free to comment/suggest changes there if you think the README could be improved. I'm closing this PR for now, thanks so much for your help :)