search

supersaiyanmode / PyWebOSTV

Python API for controlling LG TVs (Web OS)
MIT License
261 stars 50 forks source link

macOS Big Sur additional step to README.md #50

Closed ludufre closed 3 years ago

ludufre commented 3 years ago

Hi,

I'm on macOS Big Sur 11.1 (20C69) fresh install and I can only install with those additional steps.

coveralls commented 3 years ago

Coverage Status

Coverage remained the same at 83.54% when pulling 6512333b5b441e4ae1fac31a020fa8f9d8216412 on ludufre:master into 37857dc2e0b445ad740dad2a7f450f9189280b05 on supersaiyanmode:master.

supersaiyanmode commented 3 years ago

The dependency of cryptography should already be there in requirements.txt via requests[security]. You can verify from here (under psf/requests).

At this point I am inclined to think that it is just your machine and the way it is set up. Can you confirm if you see similar behavior in an freshly create virtuanenv? Can someone else on Big Sur please confirm?

ludufre commented 3 years ago

Same behavior on my iMac 2019 and Macbook Pro 2014 with 11.1 (20C69). Fresh install (today), Xcode downloaded from App Store.

But, we can see if anyone else had this problem ...

ludufre commented 3 years ago

Just to be clear, the original error was: 'openssl/opensslv.h' file not found. With pip3 install pywebostv

supersaiyanmode commented 3 years ago

I think I understand what is going on from your error. Would you be okay to rephrase the messaging as below?

If you see errors such as openssl file not found, it most likely indicates that you don't have a working installation of OpenSSL. In such a case, we would recommend that you install it using the following steps (assuming you've brew as your package manager): [step1] [step2] ..

ludufre commented 3 years ago

Of course! No problems. I submitted a new commit. See if it's okay.

supersaiyanmode commented 3 years ago

Thanks so much @ludufre for this PR :)