I think in directReply should have extraScope too - Githubissues

superscriptjs / superscript

A dialogue engine for creating chat bots

http://superscriptjs.com

MIT License

1.65k stars 209 forks source link

I think in directReply should have extraScope too #381

Open golfapipol opened 6 years ago

golfapipol commented 6 years ago

add extraScope on directReply function via 4th parameter in reply function have it but in directReply that like do the same not have it.

Description

add extraScope on directReply function via 4th parameter in reply function have it but in directReply that like do the same not have it.

Motivation and Context

I want to use extraScope when call directReply()

How Has This Been Tested?

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[X] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[X] All new and existing tests passed.

coveralls commented 6 years ago

Coverage remained the same at 80.495% when pulling 456bd9e99a85253d35af1b8f1bf1c0dee2637dbc on golfapipol:add-extra-scope-direct-reply into d7cf87a4b3dc044526861844c3684ddf50e24184 on superscriptjs:master.