Make extraScope can access in trigger rules

golfapipol commented 6 years ago

uncommnet line:156 in helpers.js that make extraScope cannot use in trigger rules use options.system.extraScope instead of old one

Description

uncommnet line:156 in helpers.js that make extraScope cannot use in trigger rules use options.system.extraScope instead of old one

Motivation and Context

I want to use extraScope in trigger rules and found this commented code here

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[X] My code follows the code style of this project.
[X] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[X] All new and existing tests passed.

coveralls commented 6 years ago

Coverage increased (+0.07%) to 80.565% when pulling 04d197858b00ad6d14b7067fb3eda4bff62fba98 on golfapipol:make-extraScope-work-in-getReply into d7cf87a4b3dc044526861844c3684ddf50e24184 on superscriptjs:master.

golfapipol commented 6 years ago

I think we should change filterScope.message_props to filterScope.extraScope or not?

superscriptjs / superscript