search

superseriousbusiness / gotosocial

Fast, fun, small ActivityPub server.
https://docs.gotosocial.org
GNU Affero General Public License v3.0
3.61k stars 304 forks source link

[bug/0.6.0-rc1] Profile settings css issues in Safari #1175

Closed Fastidious closed 1 year ago

Fastidious commented 1 year ago

Describe the bug with a clear and concise description of what the bug is.

The profile screen has UX issues. See:

Screenshot 2022-11-29 at 10 46 14

What's your GoToSocial Version?

v0.6.0-rc1

GoToSocial Arch

amd64

Browser version

No response

What happened?

Went to profile, saw screen as above

What you expected to happen?

I expected to see a profile screen that allowed me to upload avatar and banner images.

How to reproduce it?

Go to https://instance/user.

Anything else we need to know?

No response

tsmethurst commented 1 year ago

This looks like you only did a partial update of the frontend assets. Are you running with docker, or the tarred binary/assets? If the latter, make sure you untar all the assets/css properly + replace any existing css/js files with the new ones.

Fastidious commented 1 year ago

@tsmethurst I am using the tar.gz. I deleted the working web directory, and copied over the one from the tarball. Still the same issue. Flushed browser's cache, still the same issue.

tsmethurst commented 1 year ago

hmm, which browser are you using?

Fastidious commented 1 year ago

Found the bug! It only happens on Safari.

tsmethurst commented 1 year ago

It only happens on Safari.

alright :) will try to get a fix in before the release proper, thanks!

kingmath commented 1 year ago

Same issue with Safari in iOS 15.7.1. Screen was photographed in two parts.

IMG_0164

IMG_0165

po5 commented 1 year ago

I experienced issues on my instance too. The issue is that the css from the previous version is cached.
Everything is fine for existing users after a hard reload, and for new users by default.
We should use the software version as a query string to break browser's cache when updating.

Fastidious commented 1 year ago

@po5 when it happened to me, I tried it on a different browser (that was never used to access my instance), and even tried on incognito mode. Still same results. I don't think it is what you think it is.

f0x52 commented 1 year ago

@Fastidious there's some suspicion it might still be caching, could you check the devtools to see if it's a cached response?

f0x52 commented 1 year ago

update: I can reproduce the issue in Epiphany, so it's not caching related

joepie91 commented 1 year ago

This should probably be reported to https://webcompat.com/

Fastidious commented 1 year ago

@tsmethurst waiting for this to make it to an RC, because I can’t see the /admin settings neither, on Safari (they show fine under Chrome). #1193 might fix it, but no way to test it yet.