superseriousbusiness / gotosocial

Fast, fun, small ActivityPub server.
https://docs.gotosocial.org
GNU Affero General Public License v3.0
3.61k stars 304 forks source link

[bug] Missing field "sensitive" in CredentialAccount #1332

Closed baummarten closed 1 year ago

baummarten commented 1 year ago

Describe the bug with a clear and concise description of what the bug is.

I'm not sure if it's a GoToSocial bug or overzealous parsing on the side of mastodon-async library which I'm using, but both Mastodon and Akkoma do provide that field.

What's your GoToSocial Version?

6.0.0

GoToSocial Arch

amd64, binary

Browser version

No response

What happened?

Got a response:

{
   "id":"[redacted]",
   "username":"[redacted]",
   "acct":"[redacted]",
   "display_name":"[redacted]",
   "locked":true,
   "bot":false,
   "created_at":"[redacted]",
   "note":"",
   "url":"[redacted]",
   "avatar":"[redacted]",
   "avatar_static":"[redacted]",
   "header":"[redacted]",
   "header_static":"[redacted]",
   "followers_count":1,
   "following_count":1,
   "statuses_count":1,
   "last_status_at":"[redacted]",
   "emojis":[

   ],
   "fields":[

   ],
   "source":{
      "privacy":"unlisted",
      "language":"en",
      "status_format":"plain",
      "note":"",
      "fields":[

      ]
   },
   "role":"admin"
}

What you expected to happen?

source should contain a sensitive boolean field as per docs for CredentialAccount.

How to reproduce it?

GET <my_instance.my_domain>/api/v1/accounts/verify_credentials using an authenticated app.

Anything else we need to know?

No response

darrinsmart commented 1 year ago

Quick update: The Ice Cubes client was failing to log in due to this missing field. I switched from the 0.6.0 binary download to using the git source (with this fix), and now I'm able to log in and view my timeline. Well done and thanks!