search

superseriousbusiness / gotosocial

Fast, fun, small ActivityPub server.
https://docs.gotosocial.org
GNU Affero General Public License v3.0
3.71k stars 319 forks source link

[chore] Use `(created)` pseudo-header for HTTP Signatures instead of `Date` #2991

Open tsmethurst opened 3 months ago

tsmethurst commented 3 months ago

As raised in this issue -- https://github.com/superseriousbusiness/gotosocial/issues/2857 -- (created) is recommended by the HTTP signature spec draft we currently use.

We tried introducing this change here -- https://github.com/superseriousbusiness/gotosocial/pull/2969 -- in 0.16.0-rc1. Unfortunately, that change broke compatibility with Akkoma/Pleroma (https://akkoma.dev/AkkomaGang/akkoma/issues/797), and possibly Bookwyrm as well; works fine with Mastodon + the *keys however.

Once at least the *omas are capable of handling the (created) pseudo-header properly, we should switch back to using it instead, since we're actually going against the recommendations of the HTTP signature spec by not using it.

FloatingGhost commented 3 months ago

hey there, me from akkoma here

i built and tried out 69aba377bc8feac01889327f47eb4efe48b263c7 - one commit before the (created) rollback

i was able to communicate with https://ihatebeinga.live , where i was running an updated akkoma version to handle this

the server is up for you to verify if you want, but i'll merge and close our side