search

superseriousbusiness / gotosocial

Fast, fun, small ActivityPub server.
https://docs.gotosocial.org
GNU Affero General Public License v3.0
3.75k stars 322 forks source link

[bug] object of type person missing inbox #3069

Closed mro closed 3 months ago

mro commented 3 months ago

Describe the bug with a clear and concise description of what the bug is.

when dereferencing the key-id of signed http responses, gotosocial returns a sparse activitypub object declared of type person. But it has no inbox property and so can't be parsed.

somewhat related to #2961

What's your GoToSocial Version?

0.16.0

GoToSocial Arch

No response

What happened?

the returned object of type person lacks the inbox property.

What you expected to happen?

a valid activitypub object

How to reproduce it?

a signed get to https://social.nlnet.nl/users/gerben and then to the key id mentioned in there https://social.nlnet.nl/users/gerben/main-key namely.

Anything else we need to know?

No response

tsmethurst commented 3 months ago

This is documented here: https://docs.gotosocial.org/en/latest/federation/http_signatures/#quirks Not a bug but a known quirk we'll fix at some point.

mro commented 1 month ago

@tsmethurst when do you plan to comply to AP in this regard? (Tracked at https://seppo.social/issues/13)

tsmethurst commented 1 month ago

It's tracked here: https://github.com/superseriousbusiness/gotosocial/issues/1186

Not currently on the planning but hopefully some time within a year. It's not trivial to change this behavior without potentially breaking a bunch of other stuff.