superseriousbusiness / gotosocial

Fast, fun, small ActivityPub server.
https://docs.gotosocial.org
GNU Affero General Public License v3.0
3.81k stars 330 forks source link

[bug] HTTP Client options can't be set via env vars or cli args #3195

Open Fei1Yang opened 3 months ago

Fei1Yang commented 3 months ago

Describe the bug with a clear and concise description of what the bug is.

Run GoToSocial with GTS_HTTPCLIENT_ALLOW_IPS=10.88.0.1/16 ./gotosocial debug config --httpclient-allow-ips 10.88.0.1/16 does not set http-client.allow-ips, while ./gotosocial debug config --config-path /gotosocial/config/config.yaml with http-client.allow-ips set in that config set the option.

What's your GoToSocial Version?

0.16.0+git-f1cbf6f

GoToSocial Arch

amd64 Docker

What happened?

No response

What you expected to happen?

No response

How to reproduce it?

No response

Anything else we need to know?

No response

tsmethurst commented 3 months ago

Hiya, indeed this is known atm. To set those more "advanced" nested variables you gotta use the config.yaml file. I'll add something to the docs about this.