superseriousbusiness / gotosocial

Fast, fun, small ActivityPub server.
https://docs.gotosocial.org
GNU Affero General Public License v3.0
3.82k stars 331 forks source link

[bugfix] Fix temp table deletion causing runaway allocations #3278

Closed tsmethurst closed 2 months ago

tsmethurst commented 2 months ago

Description

If this is a code change, please include a summary of what you've coded, and link to the issue(s) it closes/implements.

If this is a documentation change, please briefly describe what you've changed and why.

This pull request addresses an issue we've been having with runaway memory allocations causing stress on the garbage collector. For some reason, deleting temporary tables causes SQLite to flip out and keep allocating memory, which is then immediately cleaned up.

This PR fixes the issue by changing the way we delete temporary tables: for Postgres, we can just use ON COMMIT DROP, which causes the temp tables to be cleaned up when the transaction ends. For SQLite, we can adjust the max conn lifetime to 5 minutes to ensure that temp tables get closed when the connection is closed + recreated.

Checklist

Please put an x inside each checkbox to indicate that you've read and followed it: [ ] -> [x]

If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).