search

superseriousbusiness / gotosocial

Fast, fun, small ActivityPub server.
https://docs.gotosocial.org
GNU Affero General Public License v3.0
3.7k stars 316 forks source link

[bug] Do not use plainAuth when no user or password #3320

Closed yonas closed 5 days ago

yonas commented 1 week ago

Describe the bug with a clear and concise description of what the bug is.

Do not use plainAuth when no user or password.

What's your GoToSocial Version?

0.16.0

GoToSocial Arch

No response

What happened?

See https://gitlab.com/commento/commento/-/merge_requests/113/diffs

Since https://github.com/golang/go/commit/701fa1c5ed8df2cde01487729c0e29c924e08050 golang fails when using plainAuth on a non TLS connection, which is not desirable when using no authentication at all.

What you expected to happen?

No response

How to reproduce it?

No response

Anything else we need to know?

No response