superseriousbusiness / gotosocial

Fast, fun, small ActivityPub server.
https://docs.gotosocial.org
GNU Affero General Public License v3.0
3.8k stars 329 forks source link

[bug] post counters should not include direct messages #3504

Open codl opened 4 days ago

codl commented 4 days ago

Describe the bug with a clear and concise description of what the bug is.

Post counters on profiles and on the instance landing page count all posts, including direct messages. This seems questionable privacy-wise, you could infer how many direct messages someone is sending by monitoring how fast their post count is increasing vs how many posts you can actually see.

What's your GoToSocial Version?

v0.17.1

GoToSocial Arch

amd64 binary

What happened?

I posted a direct message and my post count went up by 1 on my public profile, so did the global count on the landing page.

What you expected to happen?

Post count does not go up.

How to reproduce it?

Post a direct message to no-one.

Anything else we need to know?

One could argue that private posts should also not be counted, or even unlisted posts. Idk about that but I am certain that direct messages should not be counted.

tsmethurst commented 4 days ago

Ah yes we should change this indeed, thanks :)