[bug] Reposts notifications not being sent

[suflors]

Describe the bug with a clear and concise description of what the bug is.

When a post is reposted from another instance, it seems that the fact that it has been reposted by someone is not being sent to the server.

What's your GoToSocial Version?

v0.17.1+git-8a93300

GoToSocial Arch

amd64 Binary

What happened?

I made a post here on my server, and shortly after I was informed by my friend that a big account had reposted it here, however, checking my notifications, I saw nothing. Furthermore, the number of reposts listed on the post has not gone up, either.

What you expected to happen?

I expected to receive a notification and the repost number to go up.

How to reproduce it?

Repost a post from a gotosocial instance onto another instance.

Anything else we need to know?

I directed my friend to repost from a Misskey 2024.10.1 and Hollo 0.1.6 instance as well, and I did not receive notifications for either of these as well (the reposts are now gone as they un-reposted the post.)

[suflors]

I've looked at it a bit more and tried some things. Even from an instance that was able to repost something of mine and a notification was sent to me, reposting from the same instance did not notify me, nor did favoriting the post. Furthermore, I see a handful of different warning messages in the logs that look like this: Nov 02 20:15:45 Marinette gotosocial[1618]: timestamp="02/11/2024 20:15:45.571" func=streaming.(*Module).readFromWSConn level=WARN streamID=01JBQ89NA7RDAJBBFDBQWNY6EV username=kelsey requestID=8zar9vmj04000xeabza0 msg="unknown 'stream' field: {subscribe user:notification }" Not sure if this is the problem happening or not.

[suflors]

This post seems to have gotten 2 favorites, however, my notifications are still empty.

[suflors]

Suddenly, all of the notifications appeared just now, not exactly sure why. Actually, the one from wafrn did not appear still.

[tsmethurst]

This sounds more like a client problem to me, tbh, given the error you posted. Which client are you using? Re: that wafrn post, isn't it the reply to your post that's been boosted, and not your post itself?

[suflors]

Not likely to be the client, as I said it doesn't show on the actual gotosocial itself the interactions (until when I mentioned they randomly appeared). The wafrn post is my own post that's been reposted. Furthermore, I checked on 3 different clients (fedilab, elk, and phanpy), the same was the case on all 3. I'd be incredibly surprised were it not a problem with gotosocial itself thusly.

[tsmethurst]

Hmm okay. The only thing I can think of that might be causing this would be a rate limiting issue due to a misconfiguration. In your server logs, do you see the same client-ip value for all incoming connections?