superseriousbusiness / gotosocial

Fast, fun, small ActivityPub server.
https://docs.gotosocial.org
GNU Affero General Public License v3.0
3.86k stars 338 forks source link

[bug] Unable to follow or search accounts *@a.gup.pe #595

Closed carbontwelve closed 1 year ago

carbontwelve commented 2 years ago

a.gup.pe appears to be a special instance source code; I am able to follow the "accounts" there from Mastodon, with the accounts having a visual "group" tag in the mastodon web app much like accounts flagged as bots do:

image

I assume this is a new Mastodon feature as people using Misskey have reported being unable to follow accounts @a.gup.pe either.

There is an open issue on the gup.pe repository https://github.com/wmurphyrd/guppe/issues/48 where Misskey and Pleroma users have reported the same experience.

tsmethurst commented 2 years ago

We should be able to work with the Group actor type, we have specific logic allowing that. I'll have a look at it :) Thanks for opening this.

tsmethurst commented 2 years ago

Just adding a note for myself:

curl -H 'accept: application/activity+json' https://a.gup.pe/u/askfedi_de

gives:

{
  "@context": [
    "https://www.w3.org/ns/activitystreams",
    "https://w3id.org/security/v1"
  ],
  "id": "https://a.gup.pe/u/askfedi_de",
  "type": "Group",
  "inbox": "https://a.gup.pe/u/askfedi_de/inbox",
  "publicKey": {
    "id": "https://a.gup.pe/u/askfedi_de#main-key",
    "owner": "https://a.gup.pe/u/askfedi_de",
    "publicKeyPem": "-----BEGIN PUBLIC KEY-----\nMIICIjANBgkqhkiG9w0BAQEFAAOCAg8AMIICCgKCAgEAvUGYkiqMxk1SdqXlipoj\nkeeLx67X/hjGRPjwcd5Q+2w4rvKKBokNvDG7kD71oZeO07rS80H1uoJ7fhANuSSq\nrI+wDMcbjuovc8o43ABwktp+fmEN7gkmcbua1D2I+yG4I4z3y6eTk9FZgF1+P1iX\nO8aNWGZUSA0E2QGDVkXnUvHWgQSmdLGsF9NkWKb/YvP1MJwhvrBrnse7UaP0exos\nBLINu+ExGHG0eADm1hIa+g2UanrpODPgs1xBtUqobqG6OxyULuXHtAYBgtf4Tpd2\n+rpeBrHgiKuo/wKRyQda8yq3bj3Jtt9PUU8vxoYX/LRYeDyYajVKqXXwX54n819N\nZLi7KICn4Q/VQIS6BRYwomfWRU4QY7wNA4LVxx++vYSXMsrJNESs2B7lBxvBzJIP\nq+9wnJHtPFKz16Jz35gUpGdXLfw7oD9tMrR3jdRSvcDlf2mR/F5o0kZJn/AK9jtN\nZ50ZH8PclDCY7P0FPoUWpYxhopKByLVmfnldfD9Tkwu4qORg/+MQl+tjrzjjw+3p\n4h9bg/2jRLGnAI8Ui3XBkgwGils05lUjMwnslaPWG054/r+a7EN+BIG1EqZKJ9Hs\nbYdJbzDxGbSWfYtBuDCZqGGWH+9jUqPfEsgWbvWNlCS20EDYAGV8BVJg891I+OYc\nrlFsgyzxREWXtnZGI3ZgWhcCAwEAAQ==\n-----END PUBLIC KEY-----\n"
  },
  "followers": "https://a.gup.pe/u/askfedi_de/followers",
  "following": "https://a.gup.pe/u/askfedi_de/following",
  "icon": {
    "type": "Image",
    "mediaType": "image/jpeg",
    "url": "https://a.gup.pe/f/guppe.png"
  },
  "liked": "https://a.gup.pe/u/askfedi_de/liked",
  "name": "askFedi_de group",
  "outbox": "https://a.gup.pe/u/askfedi_de/outbox",
  "preferredUsername": "askfedi_de",
  "summary": "I'm a group about askFedi_de. Follow me to get all the group posts. Tag me to share with the group. Create other groups by searching for or tagging @yourGroupName@a.gup.pe"
}
bjoerns1983 commented 1 year ago

Any idea if that could be fixed? I installed my own GotoSocial Instacne couple of days ago and i think it is very good for Alpha Software but it would be great if it would be possible to follow this group accounts.

tsmethurst commented 1 year ago

https://github.com/immers-space/guppe/issues/90

bjoerns1983 commented 1 year ago

I think that wont get fixed until somebody is willing to pay for it: https://social.sengotta.net/@bjoern/statuses/01H1BQV0PVZ3445EBN2D501H0R

jeherve commented 1 year ago

I run into a similar issue when trying to follow another group, @notiz.blog@notiz.blog.

$ curl -H 'accept: application/activity+json' https://notiz.blog/@notiz.blog

{
    "@context": [
        "https:\/\/www.w3.org\/ns\/activitystreams",
        "https:\/\/w3id.org\/security\/v1",
        {
            "manuallyApprovesFollowers": "as:manuallyApprovesFollowers",
            "PropertyValue": "schema:PropertyValue",
            "schema": "http:\/\/schema.org#",
            "pt": "https:\/\/joinpeertube.org\/ns#",
            "toot": "http:\/\/joinmastodon.org\/ns#",
            "value": "schema:value",
            "Hashtag": "as:Hashtag",
            "featured": {
                "@id": "toot:featured",
                "@type": "@id"
            },
            "featuredTags": {
                "@id": "toot:featuredTags",
                "@type": "@id"
            }
        }
    ],
    "type": "Group",
    "inbox": "https:\/\/notiz.blog\/wp-api\/activitypub\/1.0\/users\/0\/inbox",
    "outbox": "https:\/\/notiz.blog\/wp-api\/activitypub\/1.0\/users\/0\/outbox",
    "following": "https:\/\/notiz.blog\/wp-api\/activitypub\/1.0\/users\/0\/following",
    "followers": "https:\/\/notiz.blog\/wp-api\/activitypub\/1.0\/users\/0\/followers",
    "streams": [],
    "preferredUsername": "notiz.blog",
    "publicKey": {
        "id": "https:\/\/notiz.blog\/@notiz.blog#main-key",
        "owner": "https:\/\/notiz.blog\/@notiz.blog",
        "publicKeyPem": "-----BEGIN PUBLIC KEY-----\r\nMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA12njJ+Y3H4b8LF4iBoPo\r\n3Z956cSyHFEg0VcKF4YHIgsIeWJSFsZ6Qr+UtzASJfR26bHMyw1WwL7GK+eI9BnM\r\nXZ0renBHdQDJhGd2Gy+JzGl6YBICQYMkZS1DEfpmtT+Es5eJDLucRfrdMiXlertw\r\nEgen\/39kafSh3sHfXj3CT3uGRZCS2EA47aKPao+UjfNWZH49o\/WCgSKU6gDdZkeL\r\nxpo\/gxRh3RhfiYqwgrkBOHYx5x6NspkJZUSlVV72kMisTtrfcuBHFppJk1DPWVT4\r\nRGYI36xYIKiFxVNg30rNXyy+DAaTL32xBqIhmfymiBnRshJju4ODEZ8s7fe1Jqa9\r\n7wIDAQAB\r\n-----END PUBLIC KEY-----"
    },
    "manuallyApprovesFollowers": false,
    "id": "https:\/\/notiz.blog\/@notiz.blog",
    "attachment": [],
    "name": "notizBlog",
    "icon": {
        "type": "Image",
        "url": "https:\/\/notiz.blog\/wp-content\/uploads\/2019\/10\/cropped-notizblog.png"
    },
    "image": {
        "type": "Image",
        "url": "https:\/\/notiz.blog\/wp-content\/uploads\/2017\/02\/cropped-Unknown-2.jpeg"
    },
    "published": "2005-12-07T15:03:14Z",
    "summary": "<p>a weblog mainly about the open, portable, interoperable, small, social, synaptic, semantic, structured, distributed, (re-)decentralized, independent, microformatted and federated social web<\/p>\n",
    "url": "https:\/\/notiz.blog\/@notiz.blog"
}

It doesn't happen for all groups, though. Here is another one that I can follow:

curl -H 'accept: application/activity+json' https://venera.social/profile/activitypubtestsuite

{
    "@context": [
        "https://www.w3.org/ns/activitystreams",
        "https://w3id.org/security/v1",
        {
            "vcard": "http://www.w3.org/2006/vcard/ns#",
            "dfrn": "http://purl.org/macgirvin/dfrn/1.0/",
            "diaspora": "https://diasporafoundation.org/ns/",
            "litepub": "http://litepub.social/ns#",
            "toot": "http://joinmastodon.org/ns#",
            "featured": {
                "@id": "toot:featured",
                "@type": "@id"
            },
            "schema": "http://schema.org#",
            "manuallyApprovesFollowers": "as:manuallyApprovesFollowers",
            "sensitive": "as:sensitive",
            "Hashtag": "as:Hashtag",
            "quoteUrl": "as:quoteUrl",
            "conversation": "ostatus:conversation",
            "directMessage": "litepub:directMessage",
            "discoverable": "toot:discoverable",
            "PropertyValue": "schema:PropertyValue",
            "value": "schema:value"
        }
    ],
    "id": "https://venera.social/profile/activitypubtestsuite",
    "diaspora:guid": "85a863ed-5864-944a-60d9-2d3317558508",
    "type": "Group",
    "following": "https://venera.social/following/activitypubtestsuite",
    "followers": "https://venera.social/followers/activitypubtestsuite",
    "inbox": "https://venera.social/inbox/activitypubtestsuite",
    "outbox": "https://venera.social/outbox/activitypubtestsuite",
    "featured": "https://venera.social/featured/activitypubtestsuite",
    "preferredUsername": "activitypubtestsuite",
    "name": "Activitypub Testsuite",
    "summary": "<p>A public group for discussion of developing software test stuite for ActivityPub akin to that created for Webmetion compatibility testing: <a href=\"https://webmention.rocks\" target=\"_blank\" rel=\"noopener noreferrer\">https://webmention.rocks</a></p><p>Joining and contributing to a Friendica group is easy. To share your posts, follow these steps:</p><p>1. Follow this group.<br>2. To post to the group, post on Mastodon as normal and @mention this group.<br>3. The group will then boost your post.</p><p>You don't need to be a Friendica user to join this group. Because Friendica is part of the fediverse, this group is available to everyone -- including people who use Mastodon!</p><p>Doc showing examples of past open source ActivtyPub Test Suites:<br><a href=\"https://is.gd/U6BB0C\" target=\"_blank\" rel=\"noopener noreferrer\">https://is.gd/U6BB0C</a></p>",
    "url": "https://venera.social/profile/activitypubtestsuite",
    "manuallyApprovesFollowers": false,
    "discoverable": true,
    "publicKey": {
        "id": "https://venera.social/profile/activitypubtestsuite#main-key",
        "owner": "https://venera.social/profile/activitypubtestsuite",
        "publicKeyPem": "-----BEGIN PUBLIC KEY-----\nMIICIjANBgkqhkiG9w0BAQEFAAOCAg8AMIICCgKCAgEApIOJAxZOUQcb0k0iq9qh\nobCvjaJel5OcKPp64vvSiP5JqSDVtLg6LXAIEnoYbdM8Rn1jk04qyvkpex1DIVDI\n3rBjQGEwTKqR9GQ3HJGTOMBEjrwCd37NuI0fXihcNMhzi6+s2AEFrTtLFTKJ7HWL\nDqEJTphL9UX4EGqnYI7LB++KVrcOl1r8t+dcS1qdvwFFT9kWLyvDDyQQO8tE2uyc\ncXfVlPdTQd9rxtvX6i4lxDXZS7rseGP4Yo3H9yrqo1T+/Kl5WKqhHoQqSS2FtrJ5\npjyzEYmThnZgbpFhUfp8kf6ITxJSROgVlN7A8xL1ZYimvVd4viM7eP4al5JSTMQi\nnENLBYOazoV5fRMq2cS2Zg0l5JkaD19nGIjw7YCmwebTnvt+H7CsjevZUWAs3qSC\naNrQnERtOt9IM07R5GZLRZ1hjc26MbfmVnXZAKR0Z8ARLZfSWjqEN+I+Kr2H7ktX\ns5FV+M1NIEetMVl2qwBN0PLrOWx48ECVTVcBY+oRZmqbue5OLjTIMMg5B0u1+54D\nsYhChqd7Dsw8jG7dsgJIgdCbvosia8rTdDYdLCFMXIfcV6bYbGvcJ1AIJrNkjLx4\nv5tgER8ceIlAB3R2Q/+DJffdkXMEZRDqI/mEf5aah7F8xOXG4OLS78R63EygfNAx\nQms3uvYoFpDEM2kHPicwgDUCAwEAAQ==\n-----END PUBLIC KEY-----\n"
    },
    "endpoints": {
        "sharedInbox": "https://venera.social/inbox"
    },
    "icon": {
        "type": "Image",
        "url": "https://venera.social/photo/profile/activitypubtestsuite.png?ts=1687440082",
        "mediaType": "image/png"
    },
    "generator": {
        "type": "Service",
        "name": "Friendica 'Giant Rhubarb' 2023.05-1518",
        "url": "https://venera.social"
    }
}

I'm using GtS 0.10.0.

cc @pfefferle

tsmethurst commented 1 year ago

I'm going to close this, since there's not really anything we can/should do from our side.

As @bjoerns1983 said, Guppe won't fix this unless they get paid for their time. This is fair enough, but not something we can do anything about.

For further commentary on this issue, better follow up on the Guppe repo instead of here: https://github.com/immers-space/guppe/issues/90

pfefferle commented 1 year ago

@tsmethurst I think the issue of @jeherve (https://github.com/superseriousbusiness/gotosocial/issues/595#issuecomment-1658090650) is something different. It is an issue with the WordPress plugin and GoToSocial and we are willing to change things! It seems to/might be an issue with . in the username!?!

Should we create a new/separate issue for that?

tsmethurst commented 1 year ago

Should we create a new/separate issue for that?

Yes please!

jeherve commented 1 year ago

I created #2044 to keep track of the above.