superseriousbusiness / gotosocial

Fast, fun, small ActivityPub server.
https://docs.gotosocial.org
GNU Affero General Public License v3.0
3.83k stars 331 forks source link

[bug] Content sizing covering complete width on UXP-based web browsers such as Pale Moon #800

Closed EchedelleLR closed 2 years ago

EchedelleLR commented 2 years ago

Describe the bug with a clear and concise description of what the bug is.

The content size, specifically the width, of the front page as far as I could test, is covering the whole web browser window.

This happens just to UXP-based web browsers, and I think that is due to a bad setting in the grid-template-columns setting a value of auto min(92%, 90ch) auto, for which min function is not available there.

What's your GoToSocial Version?

0.4.0

GoToSocial Arch

x86_64 (amd64) Binary

What happened?

The content size, specifically the width, of the front page is covering the whole web browser window.

I attach a screenshot for it: Vis4Valentine_Social_-_GoToSocial_2022-09-02_21-26-14

What you expected to happen?

Content size being seeing with a proportionate width according to the web browser window.

How to reproduce it?

Load any front page of any GoToSocial instance in version 0.4.0 with an UXP-based web browser.

Anything else we need to know?

As written before, the issue is the min function in grid-temlate-columns and more information of widely supported things are at MDN.

EchedelleLR commented 2 years ago

After some tweaking, auto minmax(auto, 90ch) auto could make the trick.

illfygli commented 2 years ago

Would it be an option to add support for min() to Pale Moon? So that other websites work better too.

EchedelleLR commented 2 years ago

Not sure how ahead is in their queue for UXP, since Web Components is a task on it too and is a big thing but generally, yes, they should with time, sooner if it is part of a standard.

Anyways, the example I wrote fixes the issue for Pale Moon (and keep it working for other web browsers) using already supported features.

Edited: seems to be a W3C Working Draft as for today yet https://drafts.csswg.org/css-values-4/#funcdef-min.

tsmethurst commented 2 years ago

Thanks for investigating this! Will try to get a fix in soon :)

EchedelleLR commented 2 years ago

Thanks to you for this incredible software. :3