superseriousbusiness / gotosocial

Fast, fun, small ActivityPub server.
https://docs.gotosocial.org
GNU Affero General Public License v3.0
3.71k stars 319 forks source link

[bug] Header in user's profile has too little height for content in UXP-based web browsers #803

Closed EchedelleLR closed 2 years ago

EchedelleLR commented 2 years ago

Describe the bug with a clear and concise description of what the bug is.

Header in user's profile has too little height for content.

I see that the header images are using a CSS property aspect-ration which is indeed used for enforcing a certain aspect ratio in pictures even if no actual picture is set.

This case is being applied to the image container and not the image itself.

What's your GoToSocial Version?

0.4.0

GoToSocial Arch

x86_64 (amd64) Binary

What happened?

Header content is partially showed in UXP-based web browsers.

What you expected to happen?

Header content is showed perfectly in UXP-based web browsers.

2022-09-04-181941_1920x1080_scrot

How to reproduce it?

Load any user profile.

Anything else we need to know?

Only tested in a profile without an picture set in the header.

aspect-ratio CSS property is a new-born property implemented in the first half of the last year as of MDN and is a working draft by the W3C.

Setting a fixed height or setting a height in parent container wrapping header-image and basic and then setting an height based on a % unit, helps to fix the issue without breaking functionality.

tsmethurst commented 2 years ago

Thanks for opening this, will investigate soon :)

EchedelleLR commented 2 years ago

I cannot believe I left the screenshot behind. Re-edited.

BTW, in this screenshot, I also edited the grid-template-columns using minmax() CSS property in order to see it better but the issue #800 is still kept in this page too.

EchedelleLR commented 2 years ago

Thank you.