search

superseriouscompany / mayte

Mayte Client
0 stars 0 forks source link

Store preferences locally and render your own profile based on those #109

Closed neilsarkar closed 6 years ago

neilsarkar commented 6 years ago

Closes #54. Opened backend issue linked there to track the backend piece for recs, but the client should be chill as long as we send down falsy (or undefined) values for private fields.

Also sets options to true by default

privacy options

benjaminben commented 6 years ago

Looks good, one concern: if someone signs up with linkedin they need to have their showInstagramHandle preference set to false or else it'll try to render the handle according to the current logic

Pending those types of bugs are accounted for I'm good to merge

neilsarkar commented 6 years ago

Mm, seems like it would not try to show in that case?

const showInstagramHandle = props.myProfile ?
      privacy.showInstagramHandle && !!props.user.instagramHandle : !!props.user.instagramHandle

wouldn't that evaluate to false if the user didn't have an instagram handle?

benjaminben commented 6 years ago

ahhh derp word missed that