superseriouscompany / mayte

Mayte Client
0 stars 0 forks source link

Fix endless login spinner #141

Closed neilsarkar closed 6 years ago

neilsarkar commented 6 years ago

Closes #110

Kekeke this was a fun one. Hard to debug but ultimately the issue was that the auto logout in request was not calling api:no, which was leaving the GET /users/me api call in a loading state, and the login view was checking that call to determine whether it was in the loading state.

Starting to realize that keying off of request signature might lead to weird bugs for future devs hmmmm...

Also bonus bugfixes: gender selector is now being keyed off the right preferences object so that logging out and back in doesn't show you the gender selector, quiz is being properly cleared after logout/deletion (bonus refactor: logout is in its own centralized action now)

neilsarkar commented 6 years ago

Also uh randomly added the Passkit framework bc I saw the toggle was off in XCode. So much for branch hygiene...