Rough Recs

[benjaminben]

This is pretty noisy from the manual install (https://www.npmjs.com/package/react-native-linear-gradient). Also take a look at what I'm doing to size the images, I need the post-layout height of the flexy recs view (accounting for the header) and couldn't find/think of another way to do it beyond placing it in the container state which feels... weird, idk. But I think it has to update after the layout size is determined which will vary by device and [I believe] only happen after initial render.

[neilsarkar]

Ya I mean the header is actually just a placeholder, I think in the final version you’ll probably just swipe between the screens? Or like ya we can definitely explicitly define a height for the header for now. What about flex: 1 instead of height: ‘100%’? IIRC there’s some way to do images that take up their full container. We did it on giggles for eg

On Fri, Oct 20, 2017 at 1:34 PM Ben notifications@github.com wrote:

@benjaminben commented on this pull request.

In app/components/RecsView.js https://github.com/superseriouscompany/mayte/pull/27#discussion_r145877116 :

@@ -11,12 +12,15 @@ import { Text, TouchableOpacity, View,

• Animated, } from 'react-native'

const useScratch = false const {width, height} = Dimensions.get('window')

Word, I tried subtracting the header height first but for some reason it wasn't behaving consistently - it actually doesn't have a set height atm, just padding atop/below the text. I ended up going this route bc it seemed like we might want the header to be somewhat dynamic in the gap between e.g iPhone SE / 8 Plus. But if we wanna go with a consistent height then subtracting that const from the window height definitely makes the most sense. Also {width: '100%', height: '100%'} didn't do it unfortunately.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/superseriouscompany/mayte/pull/27#discussion_r145877116, or mute the thread https://github.com/notifications/unsubscribe-auth/AAFEpVW9ioFaQEPkVFs9fxaqIxt1AUJ0ks5suCLkgaJpZM4QACc8 .

-- Neil

[benjaminben]

Yea no dice on flex: 1 either. Also I'd prefer to opt for sizing via explicit values since that'll presumably lead to way smoother animation long term if this is similar to web

[neilsarkar]

Just saw the gif holy shit this is fucking awesome

[benjaminben]

Lmaooo pretty sparse thus far but fsho glad you diggums ^__^ I'm excited for it to be really fresh by the time we're thru with it

[benjaminben]