search

superseriouscompany / mayte

Mayte Client
0 stars 0 forks source link

Reinstate match navigation #35

Closed neilsarkar closed 7 years ago

neilsarkar commented 7 years ago

Introducing the tabbed navigation broke the transitions in the match scene. This brings them back in the form of a temporary component called MatchBridge

worst case we can send out the testflight with this and refactor next week but now that it's green I'll try to make it clean, have an hour or two before I really have to start working on this presentation

match navigation

neilsarkar commented 7 years ago

My thoughts on cleaning things up round one:

  1. I'm going to delete a ton of code from Stage and make it dumb again
  2. I'm going to import containers instead of views in Match and remove duplicated code between Match and Chat
  3. I'm going to delete Header and put two buttons in Match: a button to go back to the chat and a button to toggle between deets and chat
  4. I'm going to audit mapped props for duplicates and things that should be handled by a lower container (e.g. Chat takes myId but could easily populate that from the store itself)
  5. Hopefully I'm going to be able to remove MatchBridge and do the switch between Matches and Match in Stage without triggering a re-render and loss of state in the TabNavigator

round two:

I'll try to add transitions between Matches and Match using a wrapped StackNavigator

benjaminben commented 7 years ago

just checked it out locally and this looks great. i'm gonna merge into master and then make another PR that includes some of the code i never PRd from earlier this week, which includes the fixes for like/pass being covered by the info popup trigger, etc. i was gonna fold them in with my PR from earlier today but i guess we should just delete the others now?