search

superseriouscompany / mayte

Mayte Client
0 stars 0 forks source link

Crashlytics integration #77

Closed neilsarkar closed 6 years ago

neilsarkar commented 6 years ago

This adds crashlytics support so that we can get crash info once the device is out in the wild.

However, based on my testing the recordError functionality won't fulfill our desire to replicate error logging similar to what we had with the glu api -- that is, being able to programatically send an error with stacktrace to the slack channel.

Still, crashlytics is valuable. So I walked it back to just the crashlytics integration and the react-native-fabric package.

We could arguably remove the js package since it's currently unused, however it's a pain in the ass to integrate since you have to do it manually bc of their cocoapod dependencies. So I figure I'll leave it in there in case we want js programmatic access to crashlytics.

neilsarkar commented 6 years ago

Closes #64

benjaminben commented 6 years ago

It looks good to me, the only thing is I can't tell what you wrote and what's part of the new lib other than what's in Scratch.js. But yea either way I'm down to have this present in the repo

benjaminben commented 6 years ago

looks like conflicts introduced since last PR

neilsarkar commented 6 years ago

yep I'll resolve now

On Wed, Jan 10, 2018 at 11:43 AM, Ben notifications@github.com wrote:

looks like conflicts introduced since last PR

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/superseriouscompany/mayte/pull/77#issuecomment-356696999, or mute the thread https://github.com/notifications/unsubscribe-auth/AAFEpfXvudP9_qwHkITuTzLMBc9pgqwNks5tJQTBgaJpZM4RYh3k .

-- Neil

neilsarkar commented 6 years ago

closed in favor of #80