superseva / mutant-year-zero

Mutant Year Zero system for FoundryVTT
GNU General Public License v3.0
8 stars 20 forks source link

Default img-human.svg does not render (actually hangs) in Firefox #106

Closed bithir closed 1 month ago

bithir commented 1 month ago

The default img-human.svg does not render in firefox and can block screens.

This is because Firefox needs the width and image attribute (not in in the style attribute).

This will fix it: <svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 512 512" width="512" height="512" style="height: 512px; width: 512px;"><path d="M0 0h512v512H0z" fill="#1e6f6b" fill-opacity="1"></path><g class="" transform="translate(0,0)" style=""><path d="M255 45.4c-24.5 0-47 11.8-63.9 33.4-16.9 21.5-27.1 52.6-27.1 86.5 0 36 12.1 67.5 31 89.5l13.5 15-19.6 4.6c-52.3 11.9-77.4 36.9-91.75 75.2-13.7 35.7-15.6 84.8-16.1 143.3H431c-.2-58.7-.5-109.3-13-145.5-13.4-39.4-37.9-64.3-94-75.4l-19.9-3.7 12.9-15.7c17.7-21.9 28.8-52.6 28.8-87.5 0-33.9-10.3-64.9-27.2-86.3-16.8-21.7-39.3-33.6-63.6-33.4z" fill="#ffffff" fill-opacity="1"></path></g></svg>

bithir commented 1 month ago

This is the same way the built-in Foundry icons are encoded as well

bithir commented 1 month ago

To reproduce:

bithir commented 1 month ago

The following svgs are missing the width/height: image

bithir commented 1 month ago

Note, the img-human.scg is not listed in that screen shot, as I fixed it in my world. For a cut-and-paste list: /home/bithir/RPG/Foundry/12/Data/systems/mutant-year-zero/assets/ico/ability_animal.svg /home/bithir/RPG/Foundry/12/Data/systems/mutant-year-zero/assets/ico/ability_human.svg /home/bithir/RPG/Foundry/12/Data/systems/mutant-year-zero/assets/ico/ability_mutant.svg /home/bithir/RPG/Foundry/12/Data/systems/mutant-year-zero/assets/ico/ability_robot.svg /home/bithir/RPG/Foundry/12/Data/systems/mutant-year-zero/assets/ico/ability.svg /home/bithir/RPG/Foundry/12/Data/systems/mutant-year-zero/assets/ico/armor.svg /home/bithir/RPG/Foundry/12/Data/systems/mutant-year-zero/assets/ico/artifact.svg /home/bithir/RPG/Foundry/12/Data/systems/mutant-year-zero/assets/ico/biohazard-black.svg /home/bithir/RPG/Foundry/12/Data/systems/mutant-year-zero/assets/ico/biohazard-grey.svg /home/bithir/RPG/Foundry/12/Data/systems/mutant-year-zero/assets/ico/chassis.svg /home/bithir/RPG/Foundry/12/Data/systems/mutant-year-zero/assets/ico/critical-injury.svg /home/bithir/RPG/Foundry/12/Data/systems/mutant-year-zero/assets/ico/critical.svg /home/bithir/RPG/Foundry/12/Data/systems/mutant-year-zero/assets/ico/gear.svg /home/bithir/RPG/Foundry/12/Data/systems/mutant-year-zero/assets/ico/img-animal.svg /home/bithir/RPG/Foundry/12/Data/systems/mutant-year-zero/assets/ico/img-ark.svg /home/bithir/RPG/Foundry/12/Data/systems/mutant-year-zero/assets/ico/img-mutant.svg /home/bithir/RPG/Foundry/12/Data/systems/mutant-year-zero/assets/ico/img-robot.svg /home/bithir/RPG/Foundry/12/Data/systems/mutant-year-zero/assets/ico/img-spaceship.svg /home/bithir/RPG/Foundry/12/Data/systems/mutant-year-zero/assets/ico/img-vehicle.svg /home/bithir/RPG/Foundry/12/Data/systems/mutant-year-zero/assets/ico/project.svg /home/bithir/RPG/Foundry/12/Data/systems/mutant-year-zero/assets/ico/radioactive-black.svg /home/bithir/RPG/Foundry/12/Data/systems/mutant-year-zero/assets/ico/skill.svg /home/bithir/RPG/Foundry/12/Data/systems/mutant-year-zero/assets/ico/talent_animal.svg /home/bithir/RPG/Foundry/12/Data/systems/mutant-year-zero/assets/ico/talent_human.svg /home/bithir/RPG/Foundry/12/Data/systems/mutant-year-zero/assets/ico/talent_mutant.svg /home/bithir/RPG/Foundry/12/Data/systems/mutant-year-zero/assets/ico/talent_robot.svg /home/bithir/RPG/Foundry/12/Data/systems/mutant-year-zero/assets/ico/talent.svg /home/bithir/RPG/Foundry/12/Data/systems/mutant-year-zero/assets/ico/trophy.svg /home/bithir/RPG/Foundry/12/Data/systems/mutant-year-zero/assets/ico/weapon.svg

superseva commented 1 month ago

Thanks for the FIX !