search

superseva / mutant-year-zero

Mutant Year Zero system for FoundryVTT
GNU General Public License v3.0
8 stars 21 forks source link

Chat Roll Enhancement #16

Closed sebastien17 closed 2 years ago

sebastien17 commented 3 years ago

Hello, I have made some chage to the Chat Roll Messages:

Not the best code cause pretty new to foundry. Tell me if your are interested I may have to change the dice roller mechanics on pushed roll. On an another topic, I will prepare some packs for MYZ. Just tell me if you want some in particular.

Example

superseva commented 3 years ago

Hi Sebastien, I didn't want to include push into the chat message for the reason of bloating events on chat render, and because of the easiest re-roll multi pushes mechanics. If you want you can release this as a module and I can check the code once I find some time in a week or two ( atm I have more than enough with my daily job)

On Sun, 14 Feb 2021 at 21:03, Sebastien notifications@github.com wrote:

Hello, I have made some chage to the Chat Roll Messages:

  • insert new "push" action button drectly in chat message
  • insert context bubble on hover push et pushed icon
  • hide pus action button from non owner user
  • new chat roll message design
  • new dice with numbers (design different from yours...)
  • compatible with your diceroller mechanics

Not the best code cause pretty new to foundry. Tell me if your are interested I may have to change the dice roller mechanics on pushed roll. On an another topic, I will prepare some packs for MYZ. Just tell me if you want some in particular.

[image: Example] https://user-images.githubusercontent.com/4561719/107887640-cb3a9380-6f07-11eb-84fe-d00fffbe2f21.jpg

You can view, comment on, or merge this pull request online at:

https://github.com/superseva/mutant-year-zero/pull/16 Commit Summary

  • Rename in test
  • Sass integration
  • Cleaning
  • Cleaning
  • Dice Chat Message overhauled
  • Chat Roll Enhancement
  • Merge pull request #1 from sebastien17/Test
  • Merge remote-tracking branch 'upstream/master'
  • Correction for development purpose
  • Change mutant-year-zero-test --> mutant-year-zero to push to upstream

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/superseva/mutant-year-zero/pull/16, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA7HI5NROGH32P5AMQQGBW3S7AUCJANCNFSM4XTRSZXQ .

-- Stevan Radojevic

sebastien17 commented 3 years ago

Hi, No problem I understand. I will try to release this as a module. Thx for answering.

superseva commented 3 years ago

It looks cool and it made me rethink the chat 'push' again. Damn I thought I made the decision but here I am weighing the option once again;)

On Mon, 15 Feb 2021 at 10:00, Sebastien notifications@github.com wrote:

Hi, No problem I understand. I will try to release this as a module. Thx for answering.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/superseva/mutant-year-zero/pull/16#issuecomment-779069894, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA7HI5I56CJZKIE6KWC32WLS7DPEBANCNFSM4XTRSZXQ .

-- Stevan Radojevic

sebastien17 commented 3 years ago

Normaly it's fully compatible with your push mechanics.