Closed sebastien17 closed 2 years ago
Hi Sebastien, I didn't want to include push into the chat message for the reason of bloating events on chat render, and because of the easiest re-roll multi pushes mechanics. If you want you can release this as a module and I can check the code once I find some time in a week or two ( atm I have more than enough with my daily job)
On Sun, 14 Feb 2021 at 21:03, Sebastien notifications@github.com wrote:
Hello, I have made some chage to the Chat Roll Messages:
- insert new "push" action button drectly in chat message
- insert context bubble on hover push et pushed icon
- hide pus action button from non owner user
- new chat roll message design
- new dice with numbers (design different from yours...)
- compatible with your diceroller mechanics
Not the best code cause pretty new to foundry. Tell me if your are interested I may have to change the dice roller mechanics on pushed roll. On an another topic, I will prepare some packs for MYZ. Just tell me if you want some in particular.
[image: Example] https://user-images.githubusercontent.com/4561719/107887640-cb3a9380-6f07-11eb-84fe-d00fffbe2f21.jpg
You can view, comment on, or merge this pull request online at:
https://github.com/superseva/mutant-year-zero/pull/16 Commit Summary
- Rename in test
- Sass integration
- Cleaning
- Cleaning
- Dice Chat Message overhauled
- Chat Roll Enhancement
- Merge pull request #1 from sebastien17/Test
- Merge remote-tracking branch 'upstream/master'
- Correction for development purpose
- Change mutant-year-zero-test --> mutant-year-zero to push to upstream
File Changes
- M .gitignore https://github.com/superseva/mutant-year-zero/pull/16/files#diff-bc37d034bad564583790a46f19d807abfe519c5671395fd494d8cce506c42947 (7)
- M README.md https://github.com/superseva/mutant-year-zero/pull/16/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5 (2)
- M css/mutant-year-zero.css https://github.com/superseva/mutant-year-zero/pull/16/files#diff-72f4e8a8c4f2773c177c4c03735e0d827cf0301543228f4eea94687a021e9ce2 (57)
- M lang/de.json https://github.com/superseva/mutant-year-zero/pull/16/files#diff-b856eeca8165aed4012d1d98ca6e927f20366c9c1272932ad9d8004358c1f38d (1)
- M lang/en.json https://github.com/superseva/mutant-year-zero/pull/16/files#diff-1d56632a2d162f99c901e53b79a6224e984c14501bca3188a85dbb4b4c5e6da1 (1)
- M lang/fr.json https://github.com/superseva/mutant-year-zero/pull/16/files#diff-0ebbae606a5ccb4e55da4ab4b367dd789a54ebe9e9033187a9f94f49c0ba89f5 (2)
- M lang/pt-br.json https://github.com/superseva/mutant-year-zero/pull/16/files#diff-caa54d9bc525fe95c41aafaf55c6e97e2776bd970e8f17d9668374a827daa568 (2)
- A module/MYZChat.js https://github.com/superseva/mutant-year-zero/pull/16/files#diff-e92e4d668abd49d76129e2a3837aa7a4d366c57f83a26f9f31f696508d7923af (33)
- M module/MYZDice.js https://github.com/superseva/mutant-year-zero/pull/16/files#diff-475ce29129f53831306a5723165f8033cfd39047b5c16a86d2eac5e4226a3ccf (36)
- A module/component/MYZDiceRoller.js https://github.com/superseva/mutant-year-zero/pull/16/files#diff-58d8104a4edb42ed5f1f0262d470a5c52b924c1f220dcf1a107ee7c7fdfb0763 (73)
- M module/component/dice-roller.js https://github.com/superseva/mutant-year-zero/pull/16/files#diff-8b4c3c2f93c0d5d0af707311b02ebaed9e02299b05a48206269ee46e5c9572a5 (11)
- M module/myz.js https://github.com/superseva/mutant-year-zero/pull/16/files#diff-edfd242e84ec7eab13544bcfae6b022608711cbfa047f21d7dcacbd3bb63cba5 (7)
- M package-lock.json https://github.com/superseva/mutant-year-zero/pull/16/files#diff-053150b640a7ce75eff69d1a22cae7f0f94ad64ce9a855db544dda0929316519 (9292)
- M package.json https://github.com/superseva/mutant-year-zero/pull/16/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519 (1)
- M packs/core-skills.db https://github.com/superseva/mutant-year-zero/pull/16/files#diff-f67a4e745501c37aa34900bd57b31ef90856209c0a9d4267f38eacd9964af975 (1)
- M scss/components/_chat.scss https://github.com/superseva/mutant-year-zero/pull/16/files#diff-0bf5a2eaea5ffa6996cbe8fd350457a0303a7545f9de2a0504082c2187205b8a (42)
- M system.json https://github.com/superseva/mutant-year-zero/pull/16/files#diff-7a47c8aa02cbf4ce4bc992e643af941a015591c994a3ef371413025aa747ddf3 (2)
- M templates/chat/roll.html https://github.com/superseva/mutant-year-zero/pull/16/files#diff-27fc1b9966e1bd1ebb434b5508bf9cf2c17e2259146f44592e439d07b15c1aef (48)
- A ui/test/dice-base-1.png https://github.com/superseva/mutant-year-zero/pull/16/files#diff-0e9536ffd76f4ba40d8331fddbe6ddef427ba9317269108de0882fd78e3f0c6c (0)
- A ui/test/dice-base-2.png https://github.com/superseva/mutant-year-zero/pull/16/files#diff-801ddb4ff90fbbfeb695b48bef364a5c7c2615df6a477330b5750f521e2867fa (0)
- A ui/test/dice-base-3.png https://github.com/superseva/mutant-year-zero/pull/16/files#diff-07fae00878f5d44810924c6dffdb20c62e74ae87a7d3f11e111c6c181158fac1 (0)
- A ui/test/dice-base-4.png https://github.com/superseva/mutant-year-zero/pull/16/files#diff-d32819c6ba23f758e792c36f80d4c89d5fac96f641d7ffd0f818e214dc33bf9d (0)
- A ui/test/dice-base-5.png https://github.com/superseva/mutant-year-zero/pull/16/files#diff-1a1bdd594a2267cfb18175a84a5ccb0f2b27270808da24e2ffc3ff718e59154f (0)
- A ui/test/dice-base-6.png https://github.com/superseva/mutant-year-zero/pull/16/files#diff-7c144800f7f41b6efd22f0358aeeef94e97d5350fad108e70c5be6316a5a6e83 (0)
- A ui/test/dice-gear-1.png https://github.com/superseva/mutant-year-zero/pull/16/files#diff-5d0ee131b21c9d963eb1a9729cb670d39fc9373d4ddc414bf772bcb5cc9e789e (0)
- A ui/test/dice-gear-2.png https://github.com/superseva/mutant-year-zero/pull/16/files#diff-a2a4b4d7d20a2a907feffa19081e8f946b1fb472ccc4e95b7926432c9f19044b (0)
- A ui/test/dice-gear-3.png https://github.com/superseva/mutant-year-zero/pull/16/files#diff-267114abe24cbba32a5ce0984917936d20ccafa9ea566a3b6a9e0b630d1bdbbb (0)
- A ui/test/dice-gear-4.png https://github.com/superseva/mutant-year-zero/pull/16/files#diff-46ece5946efa9886cac2bf3faa23eb288b408c51ff563082cb269dd9163478c2 (0)
- A ui/test/dice-gear-5.png https://github.com/superseva/mutant-year-zero/pull/16/files#diff-b5d0432dd1bf80d3638592073c9e31d944124a2658f1c2cf74c4476283dab35e (0)
- A ui/test/dice-gear-6.png https://github.com/superseva/mutant-year-zero/pull/16/files#diff-28ee92a3ab4c2f25128b3f1cd598c85b2b548866570c35b870750de46699decb (0)
- A ui/test/dice-skill-1.png https://github.com/superseva/mutant-year-zero/pull/16/files#diff-ecb889828ad6a1024e808f82be7faa469af7638643cd7bd89c5ca403f04b06e4 (0)
- A ui/test/dice-skill-2.png https://github.com/superseva/mutant-year-zero/pull/16/files#diff-cd8be80ea85338713c7906628a985812e1485a8b5b50dfb5bc498216f97aa101 (0)
- A ui/test/dice-skill-3.png https://github.com/superseva/mutant-year-zero/pull/16/files#diff-b793a4f58a201f30203b7538225bf8b5503de5dfdae415619d3f9c95f6c1d818 (0)
- A ui/test/dice-skill-4.png https://github.com/superseva/mutant-year-zero/pull/16/files#diff-eacec318d8ce34984628d263a335527e12538d389df31fb64be964a99988cac5 (0)
- A ui/test/dice-skill-5.png https://github.com/superseva/mutant-year-zero/pull/16/files#diff-b3f2df8ece0a6e516d3013d0de8267402c06f563132f285627b10bcf1496fbde (0)
- A ui/test/dice-skill-6.png https://github.com/superseva/mutant-year-zero/pull/16/files#diff-8e58cf272dc795a04c0d79b9d6df911c387dde4b9a25c66f04672c10deb18a16 (0)
Patch Links:
- https://github.com/superseva/mutant-year-zero/pull/16.patch
- https://github.com/superseva/mutant-year-zero/pull/16.diff
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/superseva/mutant-year-zero/pull/16, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA7HI5NROGH32P5AMQQGBW3S7AUCJANCNFSM4XTRSZXQ .
-- Stevan Radojevic
Hi, No problem I understand. I will try to release this as a module. Thx for answering.
It looks cool and it made me rethink the chat 'push' again. Damn I thought I made the decision but here I am weighing the option once again;)
On Mon, 15 Feb 2021 at 10:00, Sebastien notifications@github.com wrote:
Hi, No problem I understand. I will try to release this as a module. Thx for answering.
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/superseva/mutant-year-zero/pull/16#issuecomment-779069894, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA7HI5I56CJZKIE6KWC32WLS7DPEBANCNFSM4XTRSZXQ .
-- Stevan Radojevic
Normaly it's fully compatible with your push mechanics.
Hello, I have made some chage to the Chat Roll Messages:
Not the best code cause pretty new to foundry. Tell me if your are interested I may have to change the dice roller mechanics on pushed roll. On an another topic, I will prepare some packs for MYZ. Just tell me if you want some in particular.