search

superseva / mutant-year-zero

Mutant Year Zero system for FoundryVTT
GNU General Public License v3.0
8 stars 21 forks source link

Question about packs translation #47

Closed Petwag closed 2 years ago

Petwag commented 2 years ago

Good morning, I was thinking about translating the packs with the help of babel to apply the translation. Do you think the translation could be a part of that repo? something like a folder /fr-FR inside /packs for example?

Then the user can just use babel and give the path for the translation to apply?

superseva commented 2 years ago

Hi, I would need to check what is babel and how it works. The skill pack is used on character creation and each skill has a hidden filed that contains the ID of a skill. I need to see how that would work when creating a new character

superseva commented 2 years ago

This thing is also checking if there is an official content present so it picks the package from the official book if found... So it might require some taping in to that too

Petwag commented 2 years ago

I did some translation for another game and the way babel was working was that it was using the name of the original record as a key and then override dynamiccaly with the french translation. So it is not affecting the record itself and it is keeping the uniques ids.

superseva commented 2 years ago

So the skill-pack only contains the names of the skills and that should be already translatable through the fr.json translation json. all the entries starting with SKILL_*** should translate the skill names on the sheet. We can't translate the official content. That is something Free League must do

Petwag commented 2 years ago

Yes for the official content I understand, I didn't plan on putting my translation here

superseva commented 2 years ago

I took a look at babel, I am just curios what would you get with it since the only things in pack are the skill names, and those are already translatable ?

Petwag commented 2 years ago

I didn't know they were translatable like this, then we indeed don't need babel

superseva commented 2 years ago

I am not sure if the fr translation is all up to date. The best way is to download en.json and compare if all the enetries are present in fr version If you find any discrepancies just put it here and I can update

superseva commented 2 years ago

I get something like this if I change the system language to Fr Foundry_Virtual_Tabletop_5riN4mBjg6

Petwag commented 2 years ago

Yes you are right, I think I messed something on my side. My bad

Petwag commented 2 years ago

Not a big deal but it's in fact when we open the skill that the translation does not appear image

That is what babel is used for. But anyway we don't need that I think

superseva commented 2 years ago

You can still use Babel if you need it but I would like to avoid putting any Module related files in to the system and make system dependent of the module existence.