supershowwei / ImgurUploader-MarkdownMonster-Addin

6 stars 4 forks source link

Some cleanup required for adding to Addin Registry #1

Closed RickStrahl closed 6 years ago

RickStrahl commented 6 years ago

Hi, thank you for creating this Markdown Monster addin. It looks super useful.

In order to be added to the Addin registry however, it would be nice if you could clean things up a little bit. I haven't looked at code, but just looking at the screenshots there are a few things I think that should probably be addressed:

I can help with this if necessary, but you might want to take a look for yourself first.

Again, thanks and I look forward to moving this into the registry. It'll be a great addition - I know people have asked for Imgur integration a few times.

supershowwei commented 6 years ago

I updated dialog tile, bigger icon, and nicer layout.

I still do not provide configuration window. Because, it easy to use and almost do not need configurations for uploading images to imgur.

I already create a pr MarkdownMonsterAddinsRegistry repository. Please review and give me a comment in your own time.

Thanks your comments.

RickStrahl commented 6 years ago

You don't need a configuration window - MM itself doesn't do that either, I just show the config file for configuration changes.

I'll take a look later today.

Thanks.

supershowwei commented 6 years ago

I got it. I readded configuration menuitem.

RickStrahl commented 6 years ago

Great! That looks much nicer!

One more thing (still haven't time to look at the code): Wouldn't you want to store the client id in the configuration so that doesn't have to be put in each time? Either prefill it (if you think it has to be entered often. Does it?) or maybe another button on the toolbar to easily get to the configuration.

supershowwei commented 6 years ago

Of course, the client id will be saved now and it will be restored automatically on addin opened.

image