nesquena
commented
10 years ago :+1: Project looks good. A few notes:
- In the future, definitely consider additional polish for the UI by reviewing the cloning a screen tutorial and Q&A and the drawables guide.
- For tabs, try following this approach for cleaner tab listeners and better memory management.
- For a future exercise, challenge yourself to move even more of the logic into the base Fragment class and out of the extension timeline fragments. For example, the scroll listener could be set in the base class and then the "onLoadMore" could call an abstract method which is defined separately in the extended class. This approach could be used to move almost all the logic into the base except for certain key abstract methods.
- Consider adding endless scrolling pagination for all the different timelines (hint: add abstract method to the base fragment implemented within each subclass)
I have provided a detailed Project 4 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you might be able to improve your submission.
Let us know if you have any other thoughts or questions about this assignment. Hopefully you can see this coming together as a "fully fledged" twitter client with some more work and polish. This app contains all of the components now (fragments, models, networking, client, tab navigation, image loading, et al) of 90% of dynamic data-driven API client. Obviously there are lots of details and patterns to learn, but by this point you have been introduced to all the major frameworks and concepts. Hopefully you would feel fairly confident getting started making Android apps for instagram, pinterest, yardsale, flickr,
/cc @nesquena @timothy1ee submission for twitter project with fragments
-asavir