superspeedyplugins / issue-tracker

Submit bugs and feature requests for any of our plugins
0 stars 0 forks source link

Scalability Pro breaks Elementor editor on editing just-created template #143

Open wpshushu opened 3 months ago

wpshushu commented 3 months ago

How to reproduce the issue:

  1. Activate Elementor Pro , activate Scalability Pro 5.52
  2. Start a new Elementor container template from WP-Admin => Templates => Saved Templatees => ADD NEW TEMPLATE
  3. Elementor editor opens up and fails at this error: https://www.screencast.com/t/eibcMypBx
  4. Disable Scalability Pro, reload Elementor editor, it loads fine

Issue doesn't occur when editing existing Elementor templates, only occurs on just-created ones.

Here are component versions, although I don't think they matter.

WP version: 6.4.4 Elementor pro version: 3.21.2 Scalability Pro version: 5.52

dhilditch commented 3 months ago

@wpshushu this sounds like this would be fixed if you changed the visibility option in SPRO. The one that hides private items. That is probably the conflict here. If so, please confirm in this bug so I can add info to our plugin and extra warnings about possible side-effects.

wpshushu commented 3 months ago

@dhilditch You're right. Switching off "hides private items" fixed the issue. Is there a way to programmatically enable/disable this option?

dhilditch commented 3 months ago
  1. activate spro, set the 'disable private items' option
  2. activate elementor
  3. create a new elementor template

our hiding of private options in spro is breaking this 'draft' template.

Also test this:

  1. As above
  2. Create new post but do not publish
  3. Click preview

I'm guessing that also breaks, so please fix both of these. I want this to be a generic solution that works for other 'previews' etc, so maybe the solution here is to avoid running our optimisation if is_single() is true.

wpshushu commented 2 months ago

Hi, what's the status of this ticket? If there isn't a fix soon, can I use a filter HOOK to turn off private checkout conditionally.

Thanks