search

superstreamlabs / memphis-rest-gateway

Produce messages using REST to Memphis.dev station
https://docs.memphis.dev
Other
11 stars 7 forks source link

Stations can be configured to use their own specific authentication method #40

Closed sapergus closed 1 year ago

sapergus commented 1 year ago

Added configuration option so that as station can use its own authentication method. The new configuration is backward compatible with previous versions so a user who doesn't want to use the new features can still use their old configuration file.

The package github.com/tkanos/gonfig doesn't handle embedded structs, so I patch it and added the patcher version directly in conf/gonfig.go. I have informed the people behind github.com/tkanos/gonfig about the bug and how I fixed it, so maybe the'll add the fix to their package.

I have tried to document the changes and provided examples on how to use various configuration options.

idanasulin2706 commented 1 year ago

Hi @sapergus, it looks amazing and it is actually on the roadmap to allow users to have permissions to specific resources, but this is going to be implemented a bit differently. We are going to implement it in a way that on user creation you will attach a role that has permissions, this way all other adapters that will be implemented in the future (grpc/ws/etc.) we won't need to implement it again and again for each adapter

sapergus commented 1 year ago

That makes sense. Looking forward to the new version.