superstreamlabs / memphis

Memphis.dev is a highly scalable and effortless data streaming platform
https://docs.memphis.dev
Other
3.24k stars 217 forks source link

Password Validation #1246

Open wahmedswl opened 1 year ago

wahmedswl commented 1 year ago

Hi! Password validation rule regex seems to be invalid.

Error says that "Password must be at least 8 characters long, contain both uppercase and lowercase, and at least one number and one special character".

Given validatePassword("d&gP52#WA"), it should be valid but it's throwing error

https://github.com/memphisdev/memphis/blob/9967388b362edc374884fab6f988b391fba2e28d/server/memphis_handlers_user_mgmt.go#L826

wahmedswl commented 1 year ago

So, is & not allowed it's just oversight etc?

Thanks

avrhamNeeman commented 1 year ago

Hi @wahmedswl, In which version did you get this error?

wahmedswl commented 1 year ago

@avrhamNeeman v1.1.1 but the code snippet taken from the current branch.

Thanks