search

superstrong / who-is-out

Automatically creates an aggregated calendar of who and when everyone will be out of office, emails your team a digest summary, and sends a short webhook event. Works on one or many groups, all configured via Google Sheet.
MIT License
24 stars 3 forks source link

TODO: make recurring issues work more reliably #9

Open superstrong opened 5 years ago

superstrong commented 5 years ago

Currently, recurring events aren't handled perfectly, particularly in handling changes to future iterations outside the current review window.

Potential fix: when storing an event, note that it is a recurring one and attach a unique key to each iteration of the event. Whenever a change is detected to a recurring event, all future instances should be deleted and re-written with the new values.

ghost commented 4 years ago

Currently, it appears that recurring events get added to the shared calendar repeatedly (and each event on the shared calendar is recurring), so you end up with this after a few iterations:

Screen Shot 2020-02-13 at 11 50 52 AM
superstrong commented 4 years ago

@collinstocks-oscar Can you tell me anything more about this event? Such as: was is created, deleted, and created again? Or perhaps modified after being created? Are all these on one shared calendar, or multiple calendars? Is it just this recurring event, or others as well?

It's a known problem that recurring events don't work perfectly due to the way original calendar events are copied onto new calendars. Each event appears to be its own, isolated event, not part of a series that is subject to change en masse.

ghost commented 4 years ago

The event was created only once, but it's possible I modified it and saved it more than once early on, I forget. The event I created is on my personal calendar, with ooo@hioscar.com invited. I have not needed to create other OOO recurring events, but I could try experimenting if that would be helpful.

ghost commented 4 years ago

Is it possible that the copied event was accidentally created as a recurring event each week? That might explain the increasing number of duplicate events each week.

superstrong commented 4 years ago

Oh, are you saying each week it adds one more copy to the number of instances of that event? So 2, then 3, then 4, etc.

To fix it for now, try removing ooo@ from the event, waiting for a refresh cycle overnight, then adding it as a guest on the event again tomorrow.

I will look into the idea that it might be creating each copy as a fresh recurring event!

ghost commented 4 years ago

I think that's what's happening, yes. I removed it as guest a few days ago, so I just added it back again now and we'll see if the issue recurs.

On Mon, Feb 24, 2020 at 4:54 PM Robbie Mitchell notifications@github.com wrote:

Oh, are you saying each week it adds one more copy to the number of instances of that event? So 2, then 3, then 4, etc.

To fix it for now, try removing ooo@ from the event, waiting for a refresh cycle overnight, then adding it as a guest on the event again tomorrow.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/superstrong/who-is-out/issues/9?email_source=notifications&email_token=AHBUYPLH5SQNGQFRQXWVED3REQ6ZFA5CNFSM4HWCJIF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMZVVLY#issuecomment-590568111, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHBUYPJY5PVOFM64YY3IKV3REQ6ZFANCNFSM4HWCJIFQ .

-- Collin Stocks Senior Software Engineer – Provider Data Engineering They|Them|Theirs My work hours may not be your work hours -- please do not feel obligated to respond outside of your normal work day.

ghost commented 4 years ago

All the duplicates got added back overnight :(

On Tue, Feb 25, 2020 at 9:25 AM Collin Stocks collin@hioscar.com wrote:

I think that's what's happening, yes. I removed it as guest a few days ago, so I just added it back again now and we'll see if the issue recurs.

On Mon, Feb 24, 2020 at 4:54 PM Robbie Mitchell notifications@github.com wrote:

Oh, are you saying each week it adds one more copy to the number of instances of that event? So 2, then 3, then 4, etc.

To fix it for now, try removing ooo@ from the event, waiting for a refresh cycle overnight, then adding it as a guest on the event again tomorrow.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/superstrong/who-is-out/issues/9?email_source=notifications&email_token=AHBUYPLH5SQNGQFRQXWVED3REQ6ZFA5CNFSM4HWCJIF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMZVVLY#issuecomment-590568111, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHBUYPJY5PVOFM64YY3IKV3REQ6ZFANCNFSM4HWCJIFQ .

-- Collin Stocks Senior Software Engineer – Provider Data Engineering They|Them|Theirs My work hours may not be your work hours -- please do not feel obligated to respond outside of your normal work day.

-- Collin Stocks Senior Software Engineer – Provider Data Engineering They|Them|Theirs My work hours may not be your work hours -- please do not feel obligated to respond outside of your normal work day.