supertokens / docs

SuperTokens documentation
42 stars 73 forks source link

docs: update images to reflect changes after button CSS change #557

Closed wtusfo closed 1 year ago

wtusfo commented 1 year ago

Summary of change

Updates the screenshots for recipes that involve thirdparty providers

Related issues

Checklist

netlify[bot] commented 1 year ago

Deploy Preview for admiring-bhabha-7b1be9 ready!

Name Link
Latest commit 2e7bd757a13a3af264318bc1402da41e3718d40c
Latest deploy log https://app.netlify.com/sites/admiring-bhabha-7b1be9/deploys/63a0619c5e365a000951fb14
Deploy Preview https://deploy-preview-557--admiring-bhabha-7b1be9.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

wtusfo commented 1 year ago
  • Please update the PR title to match conventional commits or remove "chore"; matching the conventional commits is more important in the SDK repos and not that useful here
  • Fix the title to explain the point of the PR. Just saying update docs in the title of a PR into the "docs" repo isn't very descriptive :) Something like: docs: update images after social button CSS change is fine.
  • Please also check these images. If any of them are unused, you can delete them.
v2/static/img/thirdpartypasswordless-email.png
v2/static/img/thirdpartypasswordless-no-email.png
v2/static/img/thirdpartypasswordless/signinup-light.png
v2/static/img/recipe-tabs/recipe-passwordless-social.png
v2/static/img/recipe-tabs/recipe-social.png
v2/static/img/thirdparty/override/find-component
v2/static/img/thirdparty/dark-theme.png
v2/static/img/thirdparty/inspect-button.png
v2/static/img/thirdparty/react-override-octocat.png
v2/static/img/thirdparty/title-border.png
v2/static/img/thirdpartyemailpassword/override/find-component.png
v2/static/img/thirdpartyemailpassword/custom-field-name-signup.png
v2/static/img/thirdpartyemailpassword/modified-formfields.png
v2/static/img/thirdpartyemailpassword/react-override-octocat.png
v2/static/img/thirdpartyemailpassword/signin-dark.png
v2/static/img/thirdpartyemailpassword/signin-light.png
v2/static/img/thirdpartyemailpassword/signup-centered-blue-button.png
v2/static/img/thirdpartyemailpassword/signup-dark.png
v2/static/img/thirdpartyemailpassword/signup-invalid-age-light.png
v2/static/img/thirdpartyemailpassword/signup-light.png
v2/static/img/thirdpartyemailpassword/signup-with-name-and-age.png
v2/static/img/thirdpartypasswordless/override/find-component.png
porcellus commented 1 year ago

Fair enough. Still, please check if those images are used in the documentation; this one is used but not updated: https://deploy-preview-557--admiring-bhabha-7b1be9.netlify.app/docs/thirdpartyemailpassword/advanced-customizations/react-component-override/usage (v2/static/img/thirdpartyemailpassword/override/find-component.png)