supertokens / docs

SuperTokens documentation
42 stars 74 forks source link

Fix incorrect instructions for Next.js app router #732

Closed itsmingjie closed 1 year ago

itsmingjie commented 1 year ago

Summary of change

In App Router, the correct way to create a catch-all segment is through [[...segmentName]]/page.tsx, as you can no longer use dynamic routing on the leaf of directories. Supertokens' app directory example is correct.

Related commits

Seems like the example was also super new, documentation typo, I presume.

Checklist

netlify[bot] commented 1 year ago

Deploy Preview for admiring-bhabha-7b1be9 ready!

Name Link
Latest commit 99efd77db644e865bc6f9a2aa8f626d00b22cbcf
Latest deploy log https://app.netlify.com/sites/admiring-bhabha-7b1be9/deploys/6535fd57cd5a060008a0c1be
Deploy Preview https://deploy-preview-732--admiring-bhabha-7b1be9.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

nkshah2 commented 1 year ago

Hi @itsmingjie

Thanks for the PR, Ive updated your branch to also include the changes you made in other recipes,