supertokens / docs

SuperTokens documentation
39 stars 64 forks source link

fix: guides page images rendering issue #771

Closed Chakravarthy7102 closed 5 months ago

Chakravarthy7102 commented 5 months ago

Summary of change

Using normal JS variables in the place react state to store the icons paths.

Cause for the issue.

The reason why the flicker was happening in the first place is that the src url for the image tag is provided on the client side some time after rendering the html.

Why this behaviour?

So last week we have fixed missing/duplicate alt attribute to images so that's when this bug got introduced. Since before that there were no alt tags this behaviour never observed.

Previous build guides.html output Screenshot 2024-01-08 at 6 26 35 PM

after fix Screenshot 2024-01-08 at 6 28 08 PM

Related issues

Checklist

Remaining TODOs for this PR

netlify[bot] commented 5 months ago

Deploy Preview for admiring-bhabha-7b1be9 ready!

Name Link
Latest commit 4a7cea29698fc7bb3edb35328b5fda6c0090436d
Latest deploy log https://app.netlify.com/sites/admiring-bhabha-7b1be9/deploys/659bf064953f4e0008630eb0
Deploy Preview https://deploy-preview-771--admiring-bhabha-7b1be9.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.