supertokens / supertokens-auth-react

ReactJS authentication module for SuperTokens
https://supertokens.com
Other
276 stars 84 forks source link

fix: flaky e2e tests #777

Closed anku255 closed 9 months ago

anku255 commented 9 months ago

Summary of change

I noticed "Successful signin with user input code in another tab" tab was flaky because the test wasn't waiting for successful signin in "another tab" before refreshing the "first tab". It might refresh the "first tab" before the signin was complete and in that case we wouldn't find .sessionInfo-user-id class. I have fixed that case in this PR by waiting for successful sign in in another tab first.

Test Plan

Ran tests locally.

Documentation changes

(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)

Checklist for important updates

github-actions[bot] commented 9 months ago

size-limit report 📦

Path Size
lib/build/index.js 14.46 KB (0%)
recipe/session/index.js 15.38 KB (0%)
recipe/session/prebuiltui.js 18.14 KB (0%)
recipe/thirdpartyemailpassword/index.js 30.17 KB (0%)
recipe/thirdparty/index.js 26.79 KB (0%)
recipe/emailpassword/index.js 10.23 KB (0%)
recipe/emailverification/index.js 7.47 KB (0%)
recipe/passwordless/index.js 63.9 KB (0%)
recipe/thirdpartypasswordless/index.js 83.92 KB (0%)
recipe/emailverification/prebuiltui.js 22.82 KB (0%)
recipe/thirdpartyemailpassword/prebuiltui.js 54.4 KB (0%)
recipe/thirdparty/prebuiltui.js 38.89 KB (0%)
recipe/emailpassword/prebuiltui.js 28.16 KB (0%)
recipe/passwordless/prebuiltui.js 103.01 KB (0%)
recipe/thirdpartypasswordless/prebuiltui.js 130.18 KB (0%)
recipe/multitenancy/index.js 6.28 KB (0%)