fix: Remove !important from css styles

anku255 commented 5 months ago

Summary of change

This PR removes the !important declaration from the CSS styles.

Test Plan

No further changes were needed after removing the !important styles to keep the existing styles. Here is the screenshot after making this change -

Documentation changes

(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)

Checklist for important updates

[ ] Changelog has been updated
[ ] frontendDriverInterfaceSupported.json file has been updated (if needed)
[ ] Changes to the version if needed
- In package.json
- In package-lock.json
- In lib/ts/version.ts
[x] Had run npm run build-pretty
[x] Had installed and ran the pre-commit hook
[ ] Issue this PR against the latest non released version branch.
- To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
- If no such branch exists, then create one from the latest released branch.
[ ] If added a new recipe interface, then make sure that the implementation of it uses NON arrow functions only (like someFunc: function () {..}).
[ ] If I added a new recipe, I also added the recipe entry point into the size-limit section of package.json with the size limit set to the current size rounded up.
[ ] If I added a new recipe, I also added the recipe entry point into the rollup.config.mjs

rishabhpoddar commented 5 months ago

It seems like you have done manual testing of this for just a few cases? We need a more robust way of testing and making sure nothing broke. In the MFA branch, we have added story book which helps know about changes in the UI. So make this PR on top of the MFA branch and check the storybook thing to see that nothing broke?

anku255 commented 5 months ago

It seems like you have done manual testing of this for just a few cases? We need a more robust way of testing and making sure nothing broke. In the MFA branch, we have added story book which helps know about changes in the UI. So make this PR on top of the MFA branch and check the storybook thing to see that nothing broke?

I have tested it in storybook and in the example app as well. No further changes are required after removing !important declaration to keep the existing styles.

PS: The styles did break in storybook but I was able to fix that by using similar css loader as we do in our build process.

supertokens / supertokens-auth-react