Open rishabhpoddar opened 1 month ago
[x] OIDC discovery endpoint in provider config deosn't have the well-known path and all
[x] If i add a provider config via API (like google workspaces), and then I visit that on the dashboard, it does not show the hd in additional config (NOW)
[x] supertokens_max_cdi_version should not show up in core config on dashboard (NOW). This will be done via a new annotation in the core like @HideFromDashboard
which will prevent it from showing up for self hosted or saas.
[ ] If I enable third party for a tenant, and then i click on cancel in the popup that it keeps third party enabled. Is that ok? If so, then once third party is enabled, we can directly show the third party selection ui. If the user clicks on cancel there, show a warning on the UI saying that at least one provider must be selected, otherwise an error will be thrown (if no other first factor is enabled).
[ ] for self hosted users, the config in public tenant are not modifiable at all on the dashboard - pretty bad experience.
[x] For saas users, what config will they be able to modify in non root CUD, public app, public tenant? (NOW)
[ ] If i add a a custom provider, and do not specify any oidc endpoint nor the authorization urls etc, it allows me to save it anyway. We should change the flow to accept third party id and name before, and then based on that, the form should have prefilled values for OIDC or other endpoints, if those are configured in the core or static for this third party id. If they are not configured in the core or static, the then user must fill in OIDC OR (authorization, user info, token exchange).
[x] Name should be compulsory for custom SAML and custom OAuth (NOW)
[x] When adding SAML provider, the name should not be SAML, but it should give the user an option to choose from a list of names that we have support for (see this), including SAML. Show a drop down (NOW).
[x] The API keys config should be hidden from the dashboard? It's a security risk, no? (NOW)
[x] For SAML, need to allow users to upload xml and stuff on our dashboard
[x] When modifying an existing SAML provider, the urls for authorization and all have undefined
instead of the previously provided url (NOW)
[ ] In provider listing (the ones that are already added), we need to separate out the oauth and saml providers in the UI
[x] If i have init passwordless recipe with only email, and then i clikc on otp-phone in mfa, it says "please init passwordless recipe". This is a wrong error message. It should instead say, "please change contact method of passwordless.init on the backend" (in case passwordless is initilaised, else the message right now is fine)
[x] First factor is otp-email, second factor is totp and otp-phone. After logging in with first factor, the /auth/mfa screen shows nothing. No error on console either. (NOW)
[ ] Write down steps for adding new social provider.
[x] Drop down for saml name should only be shown if the name is not coming from the backend or we create a new provider. For example, in the curl command, if i set the name to "Mock SAML", the name should show as that in the provider config (NOW)
[ ] we should show an info that changes in the dashboard will not reflect in the frontend if useDynamicLoginMethods
is not set to true (for pre-built UI)
[x] bug in delete user UI (see screenshot)
[ ] In the provider config dashboard, if I have overriden the userInfo function, it says "Custom override". Change it to "Cannot edit this because you have provided a custom override"
[ ] Need to tell users on tenant management UI that frontend's useDynamicLoginMethod: true in our frontend sdk.
[ ] Issue in search tag while switching tenants (the search results doesn't take search tags into consideration)
[ ] In provider config UI, need to add placeholders for all fields, so users know what the format is of the various fields. Especially for things like apple private key.
[ ] One thing also for dashboard is that if someone tries to create a new tenant, we have to tell them itβs a paid feature. Also, if they have not added multi tenancy, it should show them that error properly and not something went wrong.
[ ] Under the "Secondary Factors" section in the tenant config UI, explain that enabling will require all users in this tenant to setup one of those factors . If you want to do conditional MFA setup and requirement, then override the getMFARequirementForAuth function in the backend sdk config instead and keep these switched off here.
[x] with API key, manual save is not working
[x] change manual to 'via boxy api'
[ ] in docs, update boxy curl command to use auto-generated values for tenant and product
[x] check for non 200 in getThirdPartyInfo api
I also thought about how we can change the docs and flow so that by default, users dont have to init stuff on the frontend (pre built ui) and can go to the dashboard directly to start configuring the tenants and login methods. This is possible if we:
The issue with the above is that it breaks the flow of setting up:
So they get real feedback really late in the setup phase. As opposed to now, where in the first step is setup frontend, and then get to see the pre built UI immediately. Which is why we didn't go ahead with these changes
π Checklist
Release order
includeInNonPublicTenantsByDefault
and email verification claimsincludeInNonPublicTenantsByDefault
and email verification claimsπΆ Staging
Dev Tag
includeInNonPublicTenantsByDefault
in ProviderInputincludeInNonPublicTenantsByDefault
in ProviderInputOthers
with-multi-tenancy-ui
branch from rishabhpoddar/multi-tenancy-mfa to the main branchπ Documentation (test site)
π₯ Production
π» NPM and core release
π Documentation
Contents of running try.supertokens.com script: