Open rishabhpoddar opened 1 year ago
<SignInAndUp />
component in TenantLoginPage
, we should use the getRoutingComponent
- to confirm that, it still uses react router dom in case getSuperTokensRoutesForReactRouterDom
is called in the main router of the app.getTenantId
is not proper.hasAccessToCurrentDomain
to each session auth (pre built UI), we should add it to the global session.init override.hasAccessToCurrentDomain
in shouldLoadRoute
(custom UI), we should add it to the global session.init override.generateEmailVerifyTokenPOST
we do not need to pass a tenantId in the path isEmailVerifiedGET
we do not need to pass a tenantId in the path .Golang SDK feedback:
multitenancy.CreateOrUpdateThirdPartyConfig
should have skipVerification as optional - DONEAdds optional param tenantId to GetUserCount which returns total count across all tenants if not passed.
but tenant id is not optional - CHANGELOG is correct as we use pointers for optional params.getUsersThatHaveRole
Does not seem to be using tenantId in any way - DONEFromUserInfoAPI
in tpmodels.TypeUserInfoMap
has an inline type declaration - DONE
type TypeUserInfoMap struct {
FromIdTokenPayload struct {
UserId string `json:"userId,omitempty"`
Email string `json:"email,omitempty"`
EmailVerified string `json:"emailVerified,omitempty"`
} `json:"fromIdTokenPayload,omitempty"`
FromUserInfoAPI struct {
UserId string `json:"userId,omitempty"`
Email string `json:"email,omitempty"`
EmailVerified string `json:"emailVerified,omitempty"`
} `json:"fromUserInfoAPI,omitempty"`
}
From a user's point of view this typing is very ugly
UserInfoMap: tpmodels.TypeUserInfoMap{
FromUserInfoAPI: struct{UserId string "json:\"userId,omitempty\""; Email string "json:\"email,omitempty\""; EmailVerified string "json:\"emailVerified,omitempty\""}{
UserId: "id",
Email: "email",
EmailVerified: "email_verified",
},
},
We should declare another type which is then used for both FromUserInfoAPI
and FromIdTokenPayload
UnknownUserIDError
being renamed to UnknownUserIdError
- DONEUpdated return type of GetEmailForUserId in the EmailVerification recipe config. It should now return OK, EmailDoesNotExistError or UnknownUserIDError as response.
Should be updated to rename UnknownUserIDError
to UnknownUserIdError
đź“… Checklist
🔶 Staging
Dev Tag
Others
đź“š Documentation (test site)
build(
is there and make sure it passes in tenant id🔥 Production
đź’» NPM and core release
đź“š Documentation