The issue is related to the usage of echo middleware in the with-labstack-echo example. Returning the hf(c) call will fix it.
Why does it fix the issue?
Because the error returned from the handler function is ignored when you don't return its result in the middleware chain. In the example, it ignores what hf(c) returns, instead returns nil. When we return as return hf(c), the result of hf(c) will be respected.
[ ] coreDriverInterfaceSupported.json file has been updated (if needed)
Along with the associated array in supertokens/constants.go
[ ] frontendDriverInterfaceSupported.json file has been updated (if needed)
[ ] Changes to the version if needed
In supertokens/constants.go > version variable
[ ] Had installed and ran the pre-commit hook
[ ] If new thirdparty provider is added,
[ ] update switch statement in recipe/thirdparty/providers/config_utils.go file, createProvider function.
[ ] add an icon on the user management dashboard.
[ ] Issue this PR against the latest non released version branch.
To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
If no such branch exists, then create one from the latest released branch.
[ ] If access token structure has changed
Modified test in session/accessTokenVersions_test.go to account for any new claims that are optional or omitted by the core
Summary of change
The issue is related to the usage of echo middleware in the
with-labstack-echo
example. Returning thehf(c)
call will fix it.Why does it fix the issue? Because the error returned from the handler function is ignored when you don't return its result in the middleware chain. In the example, it ignores what
hf(c)
returns, instead returnsnil
. When we return asreturn hf(c)
, the result ofhf(c)
will be respected.Related issues
https://discord.com/channels/603466164219281420/1227846962477535232
Test Plan
Added a test.
Checklist for important updates
coreDriverInterfaceSupported.json
file has been updated (if needed)supertokens/constants.go
frontendDriverInterfaceSupported.json
file has been updated (if needed)supertokens/constants.go > version variable
recipe/thirdparty/providers/config_utils.go
file,createProvider
function.git tag
) in the formatvX.Y.Z
, and then find the latest branch (git branch --all
) whoseX.Y
is greater than the latest released tag.session/accessTokenVersions_test.go
to account for any new claims that are optional or omitted by the core