supertokens / supertokens-node

Node SDK for SuperTokens core
https://supertokens.com
Other
292 stars 79 forks source link

feat: added new remix directory based on NextJS #798

Closed mawentowski closed 6 months ago

mawentowski commented 6 months ago

Summary of change

The new Remix demo app makes use of the following import statement for its authentication APIs that applies to NextJS:

import { getAppDirRequestHandler } from "supertokens-node/nextjs/index.js";

Given that this function is utilized by both Remix and Next.js, this draft pull request introduces a new remix directory modeled after the existing NextJS that we can continue to build upon. Alternatively, we could refactor getAppDirRequestHandler and its related functions into a generic utility that can be invoked by either framework.

My intention is to avoid duplicating this functionality specifically for Remix or attempting to reimplement it within the application itself, as it serves the same purpose across both frameworks. I am open to ideas.

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)

Documentation changes

(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)

Checklist for important updates

Remaining TODOs for this PR

netlify[bot] commented 6 months ago

Deploy Preview for astounding-pegasus-21c111 canceled.

Name Link
Latest commit 539e120d10e77916b1e9c8622a3ba218ec702397
Latest deploy log https://app.netlify.com/sites/astounding-pegasus-21c111/deploys/65eb8e7334d996000817e332
netlify[bot] commented 6 months ago

Deploy Preview for precious-marshmallow-968a81 canceled.

Name Link
Latest commit 539e120d10e77916b1e9c8622a3ba218ec702397
Latest deploy log https://app.netlify.com/sites/precious-marshmallow-968a81/deploys/65eb8e737d350c0008119cc2
rishabhpoddar commented 6 months ago

Im closing this PR for the following reasons: