In #835 we had added a workaround to retry request without the cache field if it was not available. We were not awaiting the response and prevents the catch block from catching the error.
For some reason it worked fine locally and even on CF (for sometime) until it started breaking recently. Adding await fixes the issue.
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)
Documentation changes
(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)
Checklist for important updates
[x] Changelog has been updated
[ ] coreDriverInterfaceSupported.json file has been updated (if needed)
Along with the associated array in lib/ts/version.ts
[ ] frontendDriverInterfaceSupported.json file has been updated (if needed)
[x] Changes to the version if needed
In package.json
In package-lock.json
In lib/ts/version.ts
[x] Had run npm run build-pretty
[x] Had installed and ran the pre-commit hook
[ ] If new thirdparty provider is added,
[ ] update switch statement in recipe/thirdparty/providers/configUtils.ts file, createProvider function.
[ ] add an icon on the user management dashboard.
[ ] Issue this PR against the latest non released version branch.
To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
If no such branch exists, then create one from the latest released branch.
[ ] If have added a new web framework, update the add-ts-no-check.js file to include that
[ ] If added a new recipe / api interface, then make sure that the implementation of it uses NON arrow functions only (like someFunc: function () {..}).
[ ] If added a new recipe, then make sure to expose it inside the recipe folder present in the root of this repo. We also need to expose its types.
Summary of change
In #835 we had added a workaround to retry request without the
cachefield if it was not available. We were not awaiting the response and prevents the catch block from catching the error.For some reason it worked fine locally and even on CF (for sometime) until it started breaking recently. Adding
awaitfixes the issue.Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)
Documentation changes
(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)
Checklist for important updates
coreDriverInterfaceSupported.jsonfile has been updated (if needed)lib/ts/version.tsfrontendDriverInterfaceSupported.jsonfile has been updated (if needed)package.jsonpackage-lock.jsonlib/ts/version.tsnpm run build-prettyrecipe/thirdparty/providers/configUtils.tsfile,createProviderfunction.git tag) in the formatvX.Y.Z, and then find the latest branch (git branch --all) whoseX.Yis greater than the latest released tag.add-ts-no-check.jsfile to include thatsomeFunc: function () {..}).