This commit fixes the updated domain parse util function (that uses tldts) to make sure all tests pass.
Tests were failing as a side effect of #930 due to some behavioural changes between psl and tldts.
Related issues
Test Plan
Both config.test.js and utils.test.js should pass
Documentation changes
(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)
Checklist for important updates
[ ] Changelog has been updated
[ ] coreDriverInterfaceSupported.json file has been updated (if needed)
Along with the associated array in lib/ts/version.ts
[ ] frontendDriverInterfaceSupported.json file has been updated (if needed)
[ ] Changes to the version if needed
In package.json
In package-lock.json
In lib/ts/version.ts
[x] Had run npm run build-pretty
[x] Had installed and ran the pre-commit hook
[ ] If new thirdparty provider is added,
[ ] update switch statement in recipe/thirdparty/providers/configUtils.ts file, createProvider function.
[ ] add an icon on the user management dashboard.
[x] Issue this PR against the latest non released version branch.
To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
If no such branch exists, then create one from the latest released branch.
[ ] If have added a new web framework, update the add-ts-no-check.js file to include that
[ ] If added a new recipe / api interface, then make sure that the implementation of it uses NON arrow functions only (like someFunc: function () {..}).
[ ] If added a new recipe, then make sure to expose it inside the recipe folder present in the root of this repo. We also need to expose its types.
[ ] If added a new entry point, then make sure that it is importable by adding it to the exports in package.json
Summary of change
This commit fixes the updated domain parse util function (that uses tldts) to make sure all tests pass.
Tests were failing as a side effect of #930 due to some behavioural changes between
psl
andtldts
.Related issues
Test Plan
Both
config.test.js
andutils.test.js
should passDocumentation changes
(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)
Checklist for important updates
coreDriverInterfaceSupported.json
file has been updated (if needed)lib/ts/version.ts
frontendDriverInterfaceSupported.json
file has been updated (if needed)package.json
package-lock.json
lib/ts/version.ts
npm run build-pretty
recipe/thirdparty/providers/configUtils.ts
file,createProvider
function.git tag
) in the formatvX.Y.Z
, and then find the latest branch (git branch --all
) whoseX.Y
is greater than the latest released tag.add-ts-no-check.js
file to include thatsomeFunc: function () {..}
).exports
inpackage.json