We decided to update the cookie expiry to 1 year because -
Some browsers cap the max expiry to 400 days. See this for info.
Our docs mention that access token cookie expiry is 1 year.
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)
Documentation changes
(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)
Checklist for important updates
[x] Changelog has been updated
[ ] coreDriverInterfaceSupported.json file has been updated (if needed)
Along with the associated array in supertokens_python/constants.py
[ ] frontendDriverInterfaceSupported.json file has been updated (if needed)
[x] Changes to the version if needed
In setup.py
In supertokens_python/constants.py
[x] Had installed and ran the pre-commit hook
[x] Issue this PR against the latest non released version branch.
To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
If no such branch exists, then create one from the latest released branch.
[ ] If have added a new web framework, update the supertokens_python/utils.py file to include that in the FRAMEWORKS variable
[ ] If added a new recipe that has a User type with extra info, then be sure to change the User type in supertokens_python/types.py
[ ] Make sure that syncio / asyncio functions are consistent.
[ ] If access token structure has changed
Modified test in tests/sessions/test_access_token_version.py to account for any new claims that are optional or omitted by the core
Summary of change
We decided to update the cookie expiry to 1 year because -
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)
Documentation changes
(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)
Checklist for important updates
coreDriverInterfaceSupported.jsonfile has been updated (if needed)supertokens_python/constants.pyfrontendDriverInterfaceSupported.jsonfile has been updated (if needed)setup.pysupertokens_python/constants.pygit tag) in the formatvX.Y.Z, and then find the latest branch (git branch --all) whoseX.Yis greater than the latest released tag.supertokens_python/utils.pyfile to include that in theFRAMEWORKSvariablesyncio/asynciofunctions are consistent.tests/sessions/test_access_token_version.pyto account for any new claims that are optional or omitted by the core