fix: Fix error thrown by Recipe methods when ST is not initialized

prateek3255 commented 9 months ago

Summary of change

Fix "MultiTenancy not initialized" error being thrown instead of "SuperTokens not initialized" when calling recipe methods directly without initializing SuperTokens first.

Related issues

N/A

Test Plan

Verified changes by adding a test

Documentation changes

N/A

Checklist for important updates

[x] Changelog has been updated
[ ] frontendDriverInterfaceSupported.json file has been updated (if needed)
- Along with the associated array in lib/ts/version.ts
[ ] webJsInterfaceSupported.json file has been updated (if needed)
[x] Changes to the version if needed
- In package.json
- In package-lock.json
- In lib/ts/version.ts
[x] Had run npm run build-pretty
[x] Had installed and ran the pre-commit hook
[x] Issue this PR against the latest non released version branch.
- To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
- If no such branch exists, then create one from the latest released branch.

Remaining TODOs for this PR

N/A

github-actions[bot] commented 9 months ago

size-limit report 📦

Path	Size
lib/build/index.js	24.93 KB (+0.1% 🔺)
recipe/emailverification/index.js	25.2 KB (+0.09% 🔺)
recipe/emailpassword/index.js	25.11 KB (+0.13% 🔺)
recipe/thirdparty/index.js	26.16 KB (+0.14% 🔺)
recipe/thirdpartyemailpassword/index.js	28.1 KB (+0.14% 🔺)
recipe/session/index.js	22.07 KB (+0.09% 🔺)
recipe/passwordless/index.js	26.42 KB (+0.11% 🔺)
recipe/thirdpartypasswordless/index.js	28.64 KB (+0.16% 🔺)
recipe/userroles/index.js	22.32 KB (+0.09% 🔺)
recipe/multitenancy/index.js	24.58 KB (+0.15% 🔺)

prateek3255 commented 9 months ago

The size check seems to be failing on the base branch itself, have updated the size accordingly to accommodate for it

rishabhpoddar commented 9 months ago

@prateek3255 the PR size check is also failing. Some of the size increases are massive.. why? Maybe you should not import from supertokens in all the recipes and change your approach. Please rethink.

prateek3255 commented 9 months ago

the PR size check is also failing. Some of the size increases are massive.. why? Maybe you should not import from supertokens in all the recipes and change your approach. Please rethink.

The size check is actually failing because of the base branch itself as I mentioned here https://github.com/supertokens/supertokens-web-js/pull/104#issuecomment-1895709755. Although yeah the size increase is large will think of some other way to accommodate the check

prateek3255 commented 9 months ago

@prateek3255 the PR size check is also failing. Some of the size increases are massive.. why? Maybe you should not import from supertokens in all the recipes and change your approach. Please rethink.

@rishabhpoddar For this created a separate small singleton that keeps track of SuperTokens init and is used by all recipes, this not only helps with very minimal size gains but also prevents cyclic dependencies in certain recipes.

supertokens / supertokens-web-js