rishabhpoddar
commented
1 year ago Hey @zachequi what was the context of this PR, and why was it closed? Did you find a bug that needs fixing?
Closed zachequi closed 1 year ago
rishabhpoddar
commented
1 year ago Hey @zachequi what was the context of this PR, and why was it closed? Did you find a bug that needs fixing?
zachequi
commented
1 year ago Hi,
PR was opened by mistake! I forked supertokens-website and back ported some bugfixes from a newer version that were causing us issues (lack of handling of URL objects). We will upgrade supertokens soon and then won't need the fork.
Zach
On Fri, Jun 2, 2023, 9:45 PM Rishabh Poddar @.***> wrote:
Hey @zachequi https://github.com/zachequi what was the context of this PR, and why was it closed? Did you find a bug that needs fixing?
— Reply to this email directly, view it on GitHub https://github.com/supertokens/supertokens-website/pull/221#issuecomment-1574652333, or unsubscribe https://github.com/notifications/unsubscribe-auth/A2KMBF2GL774QGVKSRWQEYDXJK6QJANCNFSM6AAAAAAYY6QBJU . You are receiving this because you were mentioned.Message ID: @.***>
Summary of change
(A few sentences about this PR)
Related issues
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)
Documentation changes
(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)
Checklist for important updates
frontendDriverInterfaceSupported.jsonfile has been updated (if needed)lib/ts/version.tspackage.jsonpackage-lock.jsonlib/ts/version.tsnpm run build-prettygit tag) in the formatvX.Y.Z, and then find the latest branch (git branch --all) whoseX.Yis greater than the latest released tag.Remaining TODOs for this PR