should break out of session refresh loop if cookie writes are disabled
We removed (incognito mode) from the error message but the test wasn't updated.
test warnings when cookie writes are not successful
The error message needed to updated here as well. Along with that we needed to update the cookies check to only the frontend cookies as the backend cookies can be present even if frontend is unable to write to cookies. This test was passing previously because an additional refresh call was clearing the backend cookies as well as explained in #263
Related issues
Link to issue1 here
Link to issue1 here
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)
Documentation changes
(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)
Checklist for important updates
[ ] Changelog has been updated
[ ] frontendDriverInterfaceSupported.json file has been updated (if needed)
Along with the associated array in lib/ts/version.ts
[ ] Changes to the version if needed
In package.json
In package-lock.json
In lib/ts/version.ts
[ ] Had run npm run build-pretty
[ ] Had installed and ran the pre-commit hook
[ ] Issue this PR against the latest non released version branch.
To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
If no such branch exists, then create one from the latest released branch.
Summary of change
This PR fixes two tests -
should break out of session refresh loop if cookie writes are disabled We removed (incognito mode) from the error message but the test wasn't updated.
test warnings when cookie writes are not successful The error message needed to updated here as well. Along with that we needed to update the cookies check to only the frontend cookies as the backend cookies can be present even if frontend is unable to write to cookies. This test was passing previously because an additional refresh call was clearing the backend cookies as well as explained in #263
Related issues
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)
Documentation changes
(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)
Checklist for important updates
frontendDriverInterfaceSupported.json
file has been updated (if needed)lib/ts/version.ts
package.json
package-lock.json
lib/ts/version.ts
npm run build-pretty
git tag
) in the formatvX.Y.Z
, and then find the latest branch (git branch --all
) whoseX.Y
is greater than the latest released tag.