search

supertokens / supertokens-website

Frontend SDK for SuperTokens - for session management + automatically refreshing sessions
https://supertokens.com
Other
54 stars 13 forks source link

Documentation / Implementation mismatch #4

Closed eweitnauer closed 4 years ago

eweitnauer commented 4 years ago

In contradiction to the API docs, which say that sessionPossiblyExists returns a boolean, it actually returns a Promise.

Not only did this trip me up as I didn't expect it from reading the docs, it also seems to complicate things unnecessarily since the sessionPossiblyExists method does not actually do anything asynchronous. I'd suggest removing the async from the method.

rishabhpoddar commented 4 years ago

Thank you for pointing out this issue. It has been fixed in the latest version - 3.2.8 which has been released to npm.