Adding bundle size checking as a PR action

porcellus commented 3 years ago

Summary of change

Build change only

N/A

[x] Changelog has been updated
[x] frontendDriverInterfaceSupported.json file has been updated (if needed)
- Along with the associated array in lib/ts/version.ts
[ ] Changes to the version if needed
- In package.json
- In package-lock.json
- In lib/ts/version.ts
[x] Had run npm run build-pretty
[x] Had installed and ran the pre-commit hook
[x] Issue this PR against the latest non released version branch.
- To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
- If no such branch exists, then create one from the latest released branch.

github-actions[bot] commented 3 years ago

Path	Size
lib/build/bundleEntry.js	9.42 KB (+100% 🔺)

rishabhpoddar commented 3 years ago

This is good. However I also prefer if there is check for this in the CICD pipeline as well - when we add a dev tag. And if it crosses a certain limit, then it should fail the CICD.
This needs to be done for the react native SDK as well (should be the same as what's done here)