search

supertuxkart-sourceforge-migration / stk-migration-test

0 stars 0 forks source link

adding a snapshot function in replayRecorder class #654

Closed supertuxkart-sourceforge-migration closed 10 years ago

supertuxkart-sourceforge-migration commented 10 years ago

Author: kartikeya107

this patch is about adding an additional function in replayRecorder class to be used for taking a snapshot.

supertuxkart-sourceforge-migration commented 10 years ago

Author: hikerstk Thank you for the ticket and the patch. A few comments:

1) Please explain in more detail what a ticket is about - a snapshot can mean different things (e.g. a snapshot of a race state).

2) Do not use windows specific calls. If OS specific code is necessary, that need to be enclosed by an appropriate #ifdef.

3) We need a patch as text file, we can't use an image to apply a patch (or do you really expect us to retype everything on that image? ). Please read the svn book, a link is on our GSoC overview page.

4) Your new function is not integrated, i.e. we can't test if it works. You should add least add more code so that there is a way to actually create a screendump.

5) Lastly, first check if that functionality is not already included in STK. In this case we already have a screenshot function, see input/input_manager.cpp, search for KEY_SNAPSHOT.

So I am closing this ticket as invalid.

Cheers, Joerg