search

supertuxkart-sourceforge-migration / stk-migration-test

0 stars 0 forks source link

Coverity scan #686

Closed supertuxkart-sourceforge-migration closed 10 years ago

supertuxkart-sourceforge-migration commented 10 years ago

Author: kroartem

I've started analyzing issues found by Coverity, here is the first patch. I plan not to close this ticket until obvious issues are not fixed. For the first patch: removed 2 unsused variables, removed useless checks (category is unsigned int so there is no need to check category>=MS_INCREASE_MIN in assert, please fix me if I'm wrong), commented out dead code. regarding dead code, I'm not sure what behaviour is intended, probably it's needed to comment "break;" statement.

supertuxkart-sourceforge-migration commented 10 years ago

Author: kroartem Some more fixes, not sure I haven't broken something, but everything compiles and plays.

supertuxkart-sourceforge-migration commented 10 years ago

Author: kroartem assuming that nobody cares.