High nitro consumption

[supertuxkart-sourceforge-migration]

Author: deveee

It's about last change in nitro - r13275.

I think current consumption of nitro is too big. When I take a small bottle of nitro, I can use it by only one click. It doesn't matter how short.

Otherwise, when nitro is using (also if I don't have pushed a button), then nito effect should be shown.

[supertuxkart-sourceforge-migration]

Author: deveee In attachment patch which solves some problems with nitro.

1. Nitro effect is shown when it's used and key is not pushed.
2. Nitro is not using when I'm not on the ground, just after I pushed nitro key for a short while.

Known problems:

3. I don't have a nitro, I push the key and with pushed key I take nitro bottle. Then I can release key and nitro can be used shorter than m_min_nitro_time. Little thing, perhaps I'll fix it.

Somebody should review it.

[supertuxkart-sourceforge-migration]

Author: deveee Second patch fixes 3.

Now there is a little mess, but I think everything works :-P

[supertuxkart-sourceforge-migration]

Author: auria Hi,

You say :

When I take a small bottle of nitro, I can use it by only one click. It doesn't matter how short.

Well, this is not a bug, it is intended. When you collect a cake, you use it in one time; when you collect a nitro bottle, the idea is that it's the same, a nitro bottle is used at once as one bonus. Before it was too easy to use nitro more than intended. I know many people have gotten used to very short nitro bursts, but that was never intended and only accidental. We might tweak it a little more but the very short bursts will not come back

However I do agree it might be good to give some more visual feedback

[supertuxkart-sourceforge-migration]

Author: auria the part about visual feedback was committed in r13338, with a few additions by myself to also continue highlighting the nitro bar in the corner

[supertuxkart-sourceforge-migration]

Author: deveee I'm one of these persons which used nitro by a very short time ;) I'm not sure if it has a sense. What's a difference now between small nitro and zipper(?) from gift box? Both I can use only once and I get speedup. Adventage of nitro was that I could use it as long as I needed.

To fighting with very short nitro bursts perhaps better would be shorter time of high speed after release the key?

And what about 2? If you really want to use minimal nitro time, it should be used also when kart is on the air. Then, also nitro effect should be shown in case: m_min_nitro_time > 0.0f && !isOnGround() I'm not sure if we'll see it currently in this case, I can't check it now.

1. is really not important, but it's more correct.

[supertuxkart-sourceforge-migration]

Author: deveee In Need for Speed games you also have nitro. There it's solved in a different way. In first 1-2 seconds after press the key, car speeds up only a little. You want to push it longer because then it gives you true acceleration.

[supertuxkart-sourceforge-migration]

Author: deveee Minimal nitro consumption was changed in r14111 and now should be accetable for everyone.

Thanks Auria for reducing it ;-)